Re: [viewvc-dev] r2674 (Fix annotate views using urllib.pathname2url) breaks annotate on windows

On 6-1-2012 23:02, C. Michael Pilato wrote:
> On 01/06/2012 04:46 PM, Jens Peters wrote:
>> On 6-1-2012 22:35, C. Michael Pilato wrote:
>>> On 01/06/2012 04:32 PM, C. Michael Pilato wrote:
>>>> On 01/06/2012 03:23 PM, Jens Peters wrote:
>>>>> Original version:
>>>>> ->   rootpath    str: D:\\var\\svn\\repos\\misc
>>>>>
>>>>> drive, rootpath = os.path.splitdrive(rootpath)
>>>>> ->   drive    str: D:
>>>>> ->   rootpath    str: \\var\\svn\\repos\\misc
>>>>>
>>>>> rootpath = os.path.abspath(rootpath)
>>>>> ->   rootpath    str: D:\\var\\svn\\repos\\misc
>>>> Aha!  I was trying to reproduce this on Linux using the ntpath module
>>>> directly, but forgot that even using that module, I'll never see the
>>>> re-addition of a drive letter from .abspath() like you would on a real
>>>> Windows system.
>>>>
>>>> I'll commit your fix ASAP.
>>> DONE:
>>>
>>>      Sending        lib/vclib/svn/svn_repos.py
>>>      Transmitting file data .
>>>      Committed revision 2714.
>>>
>>> Thanks!
>>>
>> Very cool! Could you please backport that one to 1.1 as well?
>>
>> Regards,
>> Jens
> Done, along with the code that asserts that rootpaths are absolute.  (Which,
> with my luck, will fail on your system.)
>
This time the gods of python are with you, no failures or asserts and 
annotate works on my windows box :)

------------------------------------------------------
http://viewvc.tigris.org/ds/viewMessage.do?dsForumId=4251&dsMessageId=2906917

To unsubscribe from this discussion, e-mail: [[email protected]].