Re: [viewvc-users] Bug in the version 1.1.0 of OpenSuSE Package?

Thanks for  sharing the patch, Hermann.  Yeah, it looks like the OpenSuSE
package has added some bug database interlinking logic as a customization,
and is trying to do the email address mangling in more places than baseline
ViewVC is.  Hopefully the package maintainer (whoever that is) will see your
patch and make the appropriate fix.

Maurer, Hermann wrote:
> Hi folks,
> 
> the problem seems to concern OpenSuSE viewvc package only. Please see
> details below.
> 
> I've installed the version 1.1.0 of viewvc on my server and get it
> configured. When I'd like to see a diff to the previous version of a
> file I get an exception like this one:
> 
> Python Traceback
> Traceback (most recent call last):
>   File "/srv/viewvc/lib/viewvc.py", line 4101, in main
>     request.run_viewvc()
>   File "/srv/viewvc/lib/viewvc.py", line 403, in run_viewvc
>     self.view_func(self)
>   File "/srv/viewvc/lib/viewvc.py", line 3036, in view_diff
>     generate_page(request, "diff", data)
>   File "/srv/viewvc/lib/viewvc.py", line 909, in generate_page
>     template.generate(server_fp, data)
>   File "/srv/viewvc/lib/ezt.py", line 329, in generate
>     self._execute(self.program, ctx)
>   File "/srv/viewvc/lib/ezt.py", line 458, in _execute
>     step[0](step[1], ctx)
>   File "/srv/viewvc/lib/ezt.py", line 490, in _cmd_if_any
>     self._do_if(value, t_section, f_section, ctx)
>   File "/srv/viewvc/lib/ezt.py", line 522, in _do_if
>     self._execute(section, ctx)
>   File "/srv/viewvc/lib/ezt.py", line 458, in _execute
>     step[0](step[1], ctx)
>   File "/srv/viewvc/lib/ezt.py", line 532, in _cmd_for
>     for unused in iterator:
>   File "/srv/viewvc/lib/ezt.py", line 757, in next
>     self.last_item = self._iter.next() # may raise StopIteration
>   File "/srv/viewvc/lib/viewvc.py", line 2590, in __getitem__
>     item = self._get_row()
>   File "/srv/viewvc/lib/viewvc.py", line 2666, in _get_row
>     output = self._format_text(line[1:])
>   File "/srv/viewvc/lib/viewvc.py", line 2611, in _format_text
>     text = htmlify(text, cfg.options.mangle_email_addresses,
> cfg.options.buglink_base)
> NameError: global name 'cfg' is not defined
> 
> Patch: 
> --- viewvc/lib/viewvc.py    2009-05-13 22:29:26.000000000 +0200
> +++ viewvc/lib/viewvc.py    2009-05-15 16:34:16.158357742 +0200
> @@ -2610,3 +2610,3 @@
>        text = string.replace(text, ' ', '\x01nbsp;')
> -    text = htmlify(text, cfg.options.mangle_email_addresses,
> cfg.options.buglink_base)
> +    text = htmlify(text, self.cfg.options.mangle_email_addresses,
> self.cfg.options.buglink_base)
>      text = string.replace(text, '\x01', '&')
> 
> Environment:
> OS: OpenSuSE 11.0 x86_64
> Subversion: subversion-1.5.6-25.1 
> Python: python-2.5.2-26.4
> 
> Regards,
> Hermann Maurer
> 
> ------------------------------------------------------
> http://viewvc.tigris.org/ds/viewMessage.do?dsForumId=4255&dsMessageId=2271747
> 
> To unsubscribe from this discussion, e-mail: [[email protected]].


-- 
C. Michael Pilato <[email protected]>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

------------------------------------------------------
http://viewvc.tigris.org/ds/viewMessage.do?dsForumId=4255&dsMessageId=2271919

To unsubscribe from this discussion, e-mail: [[email protected]].

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkoNhIwACgkQokEGqRcG/W7mhACgnWkcnK4bjLsKMLr+6QlJ2f9A
ibsAmwaCNYRxwpQFEEkHY3fjsuI9Uwfx
=g2YW
-----END PGP SIGNATURE-----