Re: build failure on Solaris 8 with GCC 4.5.1

Thien-Thi Nguyen <[email protected]> Wed, 29 Sep 2010 21:51:35 +0200
Newsgroups gmane.comp.version-control.rcs.bugs
Message-ID <[email protected]>
() Paul Eggert <[email protected]>
() Wed, 29 Sep 2010 11:48:28 -0700

   The first problem is in the alloc function.  The expression

   ( ( divvy -> space ) ) -> temp

   is not valid, because divvy->space is of type void *.

Thanks.  I came to the same realization a few minutes after posting.
There is no real reason for ‘struct divvy’ member ‘space’ to be ‘void *’,
so in the latest sources, i have made it ‘struct obstack *’ directly
(commit dd555a1e8d3baddb8b491bcb2003c451d356b6af).

To "properly address" (har har, "pointed" humor :-) the crashes,
allocation is now always "widest type aligned"
(commit 2b893b7b24ad990b496c9c5bf4b865e0cb67fb60).

These changes have been pushed to the public repository:

  $ glog 5.7.93..
  8ea2149 [v] Centralize tests; do complicated test last.
  dd86a18 [int] Don't redundantly align atat divvy spaces.
  2b893b7 [int] Align divvy spaces to the "widest" type width.
  dd555a1 [int] Tighten type of struct ‘divvy’ member ‘space’.
  ecf54ce [v] Fix bug: Specify "./common" to avoid ‘PATH’ search.
  7e2b223 [maint] Rename top-level directory v/ to tests/.

http://git.savannah.gnu.org/cgit/rcs.git