RE: svn commit: r40417 - in trunk: . subversion/include subversion/include/private subversion/libsvn_client subversion/libsvn_subr subversion/libsvn_wc

> -----Original Message-----
> From: Arfrever Frehtes Taifersar Arahesis
> [mailto:Arfrever.FTA-/[email protected]]
> Sent: zaterdag 7 november 2009 12:14
> To: svn-lmwclWVctOZK/[email protected]
> Subject: svn commit: r40417 - in trunk: . subversion/include
> subversion/include/private subversion/libsvn_client
> subversion/libsvn_subr subversion/libsvn_wc
> 
> Author: arfrever
> Date: Fri Nov  6 15:14:00 2009
> New Revision: 40417
> 
> Log:
> Fix inclusion of svn_debug.h. Previously this private header was
> included from
> public header (svn_types.h) when SVN_DEBUG was defined. It was causing
> build
> failures when including installed svn_types.h with SVN_DEBUG defined.
> Now
> svn_debug.h is automatically included when SVN_DEBUG is defined during
> building
> of Subversion, but isn't included from installed svn_types.h when
> SVN_DEBUG is
> defined.


What do you try to fix?

SVN_DEBUG is an internal switch we use for debugging subversion itself. It should not be set by user code. And our own compilation should never use an installed svn_types.h, or we can never change this file again.

This breaks my debug/test builds where I use SVN_DBG() in source files (e.g. all over libsvn_wc). The follow-ups also break exporting the debug helpers on windows... it makes it impossible to use SVN_DBG() in a shared build?

It also breaks a static debug compilation in dso.c (in libsvn_subr)

#ifdef SVN_DEBUG
          char buf[1024];
          SVN_DBG(("%s\n", apr_dso_error(*dso, buf, 1024)));
#endif


So Again: What problem did you want to fix?

Did you try this patch in debug and release builds?
And did you try using SVN_DBG() in a file like update_editor.c? This is why this file was added.

We intended never to commit usages of SVN_DBG(), but it was not added as something we will never use.

Are you going to fix this?



	Bert

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=495&dsMessageId=2415457