Re: TortoisePLink working in TortoiseSVN 1.14.7, but not in 1.14.8

------=_Part_47902_1147756608.1729238678499
Content-Type: multipart/alternative; 
	boundary="----=_Part_47903_1096312343.1729238678499"

------=_Part_47903_1096312343.1729238678499
Content-Type: text/plain; charset="UTF-8"

onsdag 16 oktober 2024 kl. 14:47:40 UTC+2 skrev Daniel Sahlberg:

onsdag 16 oktober 2024 kl. 07:51:36 UTC+2 skrev [email protected]:


Upgrading TortoseSVN to version 1.14.8 started to show "svn: E170013: 
Unable to connect to a repository at URL 'svn+xxx://host/repo/project/trunk'

Being "xxx" a protocol defined in [tunnels] at config file, diagnosed the 
connection and was OK, tried "PLink.exe" instead of TortoisePLink.exe and 
connection was OK.

So I copied old TortoisePLink.exe from 1.14.7 to "bin" and it works.

A difference I can see:
TortoisePLink.exe from 1.14.7 if called with "-V" argument, shows version 
in dialog.
TortoisePLink.exe from 1.14.8 if called with "-V" argument, displays 
nothing.


Thanks for the report. I see the same behaviour, although I don't have time 
to fully dig into it now.

Checking the code though, there are a few things catching my eye:
* cmdline_process_param is declared in putty.h having four parameters
* It is defined in cmdline.c having five parameters
* The TortoisePlink.patch is adding the extra parameter to the definition 
and to all call sites, but not to the header file
* The code in r29707 seems to remove the extra parameter in plink.c to "fix 
build for latest VS version" (copied from the commit message)

I'm suspecting r29707 to be the cause of this issue.


There was a fix in r29732. Unfortunately I don't have a svn+ssh:// 
repository to test. Would you consider downloading a nightly build 
(https://nightlybuilds.tortoisesvn.net/latest/x64/full/) to test if this 
solves your problem?
The nightly builds are not digitally signed so the Windows 11 context menu 
will not work (TortoiseSVN will still be available by selecting Show more 
options) so you might want to take TortoisePLink.exe from the nightly build 
and install on top of 1.14.8 if testing is successful.

Kind regards,
Daniel

-- 
You received this message because you are subscribed to the Google Groups "TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/tortoisesvn-dev/a4feff92-c7bf-4c1f-b31b-8c8816de9355n%40googlegroups.com.

------=_Part_47903_1096312343.1729238678499
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div><div dir=3D"auto">onsdag 16 oktober 2024 kl. 14:47:40 UTC+2 skrev Dani=
el Sahlberg:<br /></div><blockquote style=3D"margin: 0px 0px 0px 0.8ex; bor=
der-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"><div><div dir=
=3D"auto">onsdag 16 oktober 2024 kl. 07:51:36 UTC+2 skrev <a href=3D"" rel=
=3D"nofollow">[email protected]</a>:<br /></div><blockquote style=3D"mar=
gin: 0px 0px 0px 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-=
left: 1ex;"><div><br /></div><div>Upgrading TortoseSVN to version 1.14.8 st=
arted to show "svn: E170013: Unable to connect to a repository at URL 'svn+=
xxx://host/repo/project/trunk'</div><div><br /></div><div>Being "xxx" a pro=
tocol defined in [tunnels] at config file, diagnosed the connection and was=
 OK, tried "PLink.exe" instead of TortoisePLink.exe and connection was OK.<=
/div><div><br /></div><div>So I copied old TortoisePLink.exe from 1.14.7 to=
 "bin" and it works.</div><div><br /></div><div>A difference I can see:</di=
v><div>
TortoisePLink.exe from 1.14.7 if called with "-V" argument, shows version i=
n dialog.</div><div>
<div>
TortoisePLink.exe from 1.14.8 if called with "-V" argument, displays nothin=
g.<br /></div></div></blockquote><div><br /></div></div><div><div>Thanks fo=
r the report. I see the same behaviour, although I don't have time to fully=
 dig into it now.</div><div><br /></div><div>Checking the code though, ther=
e are a few things catching my eye:</div><div>*=C2=A0cmdline_process_param =
is declared in putty.h having four parameters</div><div>* It is defined in =
cmdline.c having five parameters</div><div>* The TortoisePlink.patch is add=
ing the extra parameter to the definition and to all call sites, but not to=
 the header file</div><div>* The code in r29707 seems to remove the extra p=
arameter in plink.c to "fix build for latest VS version" (copied from the c=
ommit message)</div><div><br /></div><div>I'm suspecting r29707 to be the c=
ause of this issue.</div></div></blockquote><div><br /></div><div>There was=
 a fix in r29732. Unfortunately I don't have a svn+ssh:// repository to tes=
t. Would you consider downloading a nightly build (https://nightlybuilds.to=
rtoisesvn.net/latest/x64/full/) to test if this solves your problem?</div><=
div>The nightly builds are not digitally signed so the Windows 11 context m=
enu will not work (TortoiseSVN will still be available by selecting Show mo=
re options) so you might want to take TortoisePLink.exe from the nightly bu=
ild and install on top of 1.14.8 if testing is successful.</div><div><br />=
</div><div>Kind regards,</div><div>Daniel</div><div><br /></div></div>

<p></p>

-- <br />
You received this message because you are subscribed to the Google Groups &=
quot;TortoiseSVN-dev&quot; group.<br />
To unsubscribe from this group and stop receiving emails from it, send an e=
mail to <a href=3D"mailto:[email protected]">tor=
[email protected]</a>.<br />
To view this discussion on the web visit <a href=3D"https://groups.google.c=
om/d/msgid/tortoisesvn-dev/a4feff92-c7bf-4c1f-b31b-8c8816de9355n%40googlegr=
oups.com?utm_medium=3Demail&utm_source=3Dfooter">https://groups.google.com/=
d/msgid/tortoisesvn-dev/a4feff92-c7bf-4c1f-b31b-8c8816de9355n%40googlegroup=
s.com</a>.<br />

------=_Part_47903_1096312343.1729238678499--

------=_Part_47902_1147756608.1729238678499--