Re: TortoisePLink working in TortoiseSVN 1.14.7, but not in 1.14.8

------=_Part_95998_1435901073.1729272985849
Content-Type: multipart/alternative; 
	boundary="----=_Part_95999_584516071.1729272985849"

------=_Part_95999_584516071.1729272985849
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable


Sure thing, thanks! I can confirm it works.

Took the file TortoisePLink.exe=20
from TortoiseSVN-1.14.99.29733-dev-x64-svn-1.14.dev.msi
and installed it on top of 1.14.8

Cheers,

Juan Gabriel

El viernes, 18 de octubre de 2024 a las 10:04:38 UTC+2,=20
[email protected] escribi=C3=B3:

> onsdag 16 oktober 2024 kl. 14:47:40 UTC+2 skrev Daniel Sahlberg:
>
> onsdag 16 oktober 2024 kl. 07:51:36 UTC+2 skrev [email protected]:
>
>
> Upgrading TortoseSVN to version 1.14.8 started to show "svn: E170013:=20
> Unable to connect to a repository at URL 'svn+xxx://host/repo/project/tru=
nk'
>
> Being "xxx" a protocol defined in [tunnels] at config file, diagnosed the=
=20
> connection and was OK, tried "PLink.exe" instead of TortoisePLink.exe and=
=20
> connection was OK.
>
> So I copied old TortoisePLink.exe from 1.14.7 to "bin" and it works.
>
> A difference I can see:
> TortoisePLink.exe from 1.14.7 if called with "-V" argument, shows version=
=20
> in dialog.
> TortoisePLink.exe from 1.14.8 if called with "-V" argument, displays=20
> nothing.
>
>
> Thanks for the report. I see the same behaviour, although I don't have=20
> time to fully dig into it now.
>
> Checking the code though, there are a few things catching my eye:
> * cmdline_process_param is declared in putty.h having four parameters
> * It is defined in cmdline.c having five parameters
> * The TortoisePlink.patch is adding the extra parameter to the definition=
=20
> and to all call sites, but not to the header file
> * The code in r29707 seems to remove the extra parameter in plink.c to=20
> "fix build for latest VS version" (copied from the commit message)
>
> I'm suspecting r29707 to be the cause of this issue.
>
>
> There was a fix in r29732. Unfortunately I don't have a svn+ssh://=20
> repository to test. Would you consider downloading a nightly build (
> https://nightlybuilds.tortoisesvn.net/latest/x64/full/) to test if this=
=20
> solves your problem?
> The nightly builds are not digitally signed so the Windows 11 context men=
u=20
> will not work (TortoiseSVN will still be available by selecting Show more=
=20
> options) so you might want to take TortoisePLink.exe from the nightly bui=
ld=20
> and install on top of 1.14.8 if testing is successful.
>
> Kind regards,
> Daniel
>
>

--=20
You received this message because you are subscribed to the Google Groups "=
TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an e=
mail to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/=
tortoisesvn-dev/a088b25e-a709-4b63-a2bd-274e150dade3n%40googlegroups.com.

------=_Part_95999_584516071.1729272985849
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div><br /></div>Sure thing, thanks! I can confirm it works.<div><br /></di=
v><div>Took the file TortoisePLink.exe from=C2=A0TortoiseSVN-1.14.99.29733-=
dev-x64-svn-1.14.dev.msi</div><div>and installed it on top of 1.14.8<div><b=
r /></div><div>Cheers,</div><div><br /></div><div>Juan Gabriel<br /><div><b=
r /></div></div></div><div class=3D"gmail_quote"><div dir=3D"auto" class=3D=
"gmail_attr">El viernes, 18 de octubre de 2024 a las 10:04:38 UTC+2, daniel=
[email protected] escribi=C3=B3:<br/></div><blockquote class=3D"gmail_quote" =
style=3D"margin: 0 0 0 0.8ex; border-left: 1px solid rgb(204, 204, 204); pa=
dding-left: 1ex;"><div><div dir=3D"auto">onsdag 16 oktober 2024 kl. 14:47:4=
0 UTC+2 skrev Daniel Sahlberg:<br></div><blockquote style=3D"margin:0px 0px=
 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><d=
iv dir=3D"auto">onsdag 16 oktober 2024 kl. 07:51:36 UTC+2 skrev <a rel=3D"n=
ofollow">[email protected]</a>:<br></div><blockquote style=3D"margin:0px=
 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><di=
v><br></div><div>Upgrading TortoseSVN to version 1.14.8 started to show &qu=
ot;svn: E170013: Unable to connect to a repository at URL &#39;svn+xxx://ho=
st/repo/project/trunk&#39;</div><div><br></div><div>Being &quot;xxx&quot; a=
 protocol defined in [tunnels] at config file, diagnosed the connection and=
 was OK, tried &quot;PLink.exe&quot; instead of TortoisePLink.exe and conne=
ction was OK.</div><div><br></div><div>So I copied old TortoisePLink.exe fr=
om 1.14.7 to &quot;bin&quot; and it works.</div><div><br></div><div>A diffe=
rence I can see:</div><div>
TortoisePLink.exe from 1.14.7 if called with &quot;-V&quot; argument, shows=
 version in dialog.</div><div>
<div>
TortoisePLink.exe from 1.14.8 if called with &quot;-V&quot; argument, displ=
ays nothing.<br></div></div></blockquote><div><br></div></div><div><div>Tha=
nks for the report. I see the same behaviour, although I don&#39;t have tim=
e to fully dig into it now.</div><div><br></div><div>Checking the code thou=
gh, there are a few things catching my eye:</div><div>*=C2=A0cmdline_proces=
s_param is declared in putty.h having four parameters</div><div>* It is def=
ined in cmdline.c having five parameters</div><div>* The TortoisePlink.patc=
h is adding the extra parameter to the definition and to all call sites, bu=
t not to the header file</div><div>* The code in r29707 seems to remove the=
 extra parameter in plink.c to &quot;fix build for latest VS version&quot; =
(copied from the commit message)</div><div><br></div><div>I&#39;m suspectin=
g r29707 to be the cause of this issue.</div></div></blockquote><div><br></=
div></div><div><div>There was a fix in r29732. Unfortunately I don&#39;t ha=
ve a svn+ssh:// repository to test. Would you consider downloading a nightl=
y build (<a href=3D"https://nightlybuilds.tortoisesvn.net/latest/x64/full/"=
 target=3D"_blank" rel=3D"nofollow" data-saferedirecturl=3D"https://www.goo=
gle.com/url?hl=3Des&amp;q=3Dhttps://nightlybuilds.tortoisesvn.net/latest/x6=
4/full/&amp;source=3Dgmail&amp;ust=3D1729358910340000&amp;usg=3DAOvVaw2QOMZ=
XQDEmZs2SgQ21c-iS">https://nightlybuilds.tortoisesvn.net/latest/x64/full/</=
a>) to test if this solves your problem?</div><div>The nightly builds are n=
ot digitally signed so the Windows 11 context menu will not work (TortoiseS=
VN will still be available by selecting Show more options) so you might wan=
t to take TortoisePLink.exe from the nightly build and install on top of 1.=
14.8 if testing is successful.</div><div><br></div><div>Kind regards,</div>=
<div>Daniel</div><div><br></div></div></blockquote></div>

<p></p>

-- <br />
You received this message because you are subscribed to the Google Groups &=
quot;TortoiseSVN-dev&quot; group.<br />
To unsubscribe from this group and stop receiving emails from it, send an e=
mail to <a href=3D"mailto:[email protected]">tor=
[email protected]</a>.<br />
To view this discussion on the web visit <a href=3D"https://groups.google.c=
om/d/msgid/tortoisesvn-dev/a088b25e-a709-4b63-a2bd-274e150dade3n%40googlegr=
oups.com?utm_medium=3Demail&utm_source=3Dfooter">https://groups.google.com/=
d/msgid/tortoisesvn-dev/a088b25e-a709-4b63-a2bd-274e150dade3n%40googlegroup=
s.com</a>.<br />

------=_Part_95999_584516071.1729272985849--

------=_Part_95998_1435901073.1729272985849--