Garbled text in editorcontrol in Dark mode

Daniel Sahlberg via TortoiseSVN-dev <[email protected]> Thu, 14 Nov 2024 12:41:51 -0800 (PST)
Newsgroups gmane.comp.version-control.subversion.tortoisesvn.devel
Message-ID <[email protected]>
------=_Part_57072_1462913618.1731616911268
Content-Type: multipart/alternative; 
	boundary="----=_Part_57073_1765387463.1731616911268"

------=_Part_57073_1765387463.1731616911268
Content-Type: text/plain; charset="UTF-8"

Hi,

I've been looking at the report in the users group about garbled text in 
the edit property value dialog [1].

I can reproduce it (under Windows 11 running in Hyper-V) if I use dark mode.

A (stupid!) solution would be to invalidate the whole edit control in 
CEditPropertyValueDlg::OnEnChangePropvalue(). Surely there must be a better 
solution..?

[[[
    CRect rect;
    CWnd* pWnd = GetDlgItem(IDC_PROPVALUE);
    pWnd->GetWindowRect(&rect);
    ScreenToClient(&rect);
    InvalidateRect(&rect, TRUE);
]]]

(It works but causes a bit of flickering).

Kind regards,
Daniel


[1] https://groups.google.com/g/tortoisesvn/c/_eYSC2o6CqE

-- 
You received this message because you are subscribed to the Google Groups "TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion visit https://groups.google.com/d/msgid/tortoisesvn-dev/bd02129f-be66-4985-ba13-eb29a9d422e8n%40googlegroups.com.

------=_Part_57073_1765387463.1731616911268
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi,<div><br /><div>I've been looking at the report in the users group about=
 garbled text in the edit property value dialog [1].</div><div><br /></div>=
<div>I can reproduce it (under Windows 11 running in Hyper-V) if I use dark=
 mode.</div><div><br /></div><div>A (stupid!) solution would be to invalida=
te the whole edit control in CEditPropertyValueDlg::OnEnChangePropvalue(). =
Surely there must be a better solution..?</div><div><br /></div><div>[[[</d=
iv><div>=C2=A0 =C2=A0 CRect rect;<br />=C2=A0 =C2=A0 CWnd* pWnd =3D GetDlgI=
tem(IDC_PROPVALUE);<br />=C2=A0 =C2=A0 pWnd-&gt;GetWindowRect(&amp;rect);<b=
r />=C2=A0 =C2=A0 ScreenToClient(&amp;rect);<br />=C2=A0 =C2=A0 InvalidateR=
ect(&amp;rect, TRUE);<br /></div><div>]]]</div><div><br /></div><div>(It wo=
rks but causes a bit of flickering).</div><div><br /></div><div>Kind regard=
s,</div><div>Daniel</div><div><br /></div><div><br /></div><div>[1] https:/=
/groups.google.com/g/tortoisesvn/c/_eYSC2o6CqE<br /></div></div>

<p></p>

-- <br />
You received this message because you are subscribed to the Google Groups &=
quot;TortoiseSVN-dev&quot; group.<br />
To unsubscribe from this group and stop receiving emails from it, send an e=
mail to <a href=3D"mailto:[email protected]">tor=
[email protected]</a>.<br />
To view this discussion visit <a href=3D"https://groups.google.com/d/msgid/=
tortoisesvn-dev/bd02129f-be66-4985-ba13-eb29a9d422e8n%40googlegroups.com?ut=
m_medium=3Demail&utm_source=3Dfooter">https://groups.google.com/d/msgid/tor=
toisesvn-dev/bd02129f-be66-4985-ba13-eb29a9d422e8n%40googlegroups.com</a>.<=
br />

------=_Part_57073_1765387463.1731616911268--

------=_Part_57072_1462913618.1731616911268--