Re: Garbled text in editorcontrol in Dark mode

Stefan via TortoiseSVN-dev <[email protected]> Thu, 14 Nov 2024 13:42:13 -0800 (PST)
Newsgroups gmane.comp.version-control.subversion.tortoisesvn.devel
Message-ID <[email protected]>
------=_Part_11630_627128367.1731620533424
Content-Type: multipart/alternative; 
	boundary="----=_Part_11631_1767855625.1731620533424"

------=_Part_11631_1767855625.1731620533424
Content-Type: text/plain; charset="UTF-8"




I can reproduce it (under Windows 11 running in Hyper-V) if I use dark mode.

A (stupid!) solution would be to invalidate the whole edit control in 
CEditPropertyValueDlg::OnEnChangePropvalue(). Surely there must be a better 
solution..?

[[[
    CRect rect;
    CWnd* pWnd = GetDlgItem(IDC_PROPVALUE);
    pWnd->GetWindowRect(&rect);
    ScreenToClient(&rect);
    InvalidateRect(&rect, TRUE);
]]]


why not just use
GetDlgItem(IDC_PROPVALUE)->Invalidate();
? 

maybe there's something we could do differently in CTheme::MainSubclassProc 
? I can't reproduce this here, not even in a VM. So I won't be of much help 
:(
 

-- 
You received this message because you are subscribed to the Google Groups "TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion visit https://groups.google.com/d/msgid/tortoisesvn-dev/0384aa32-ff66-4847-99a5-add7fa202fben%40googlegroups.com.

------=_Part_11631_1767855625.1731620533424
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div><blockquote style=3D"margin: 0px 0px 0px 0.8ex; border-left: 1px solid=
 rgb(204, 204, 204); padding-left: 1ex;"><div><div><br /></div><div>I can r=
eproduce it (under Windows 11 running in Hyper-V) if I use dark mode.</div>=
<div><br /></div><div>A (stupid!) solution would be to invalidate the whole=
 edit control in CEditPropertyValueDlg::OnEnChangePropvalue(). Surely there=
 must be a better solution..?</div><div><br /></div><div>[[[</div><div>=C2=
=A0 =C2=A0 CRect rect;<br />=C2=A0 =C2=A0 CWnd* pWnd =3D GetDlgItem(IDC_PRO=
PVALUE);<br />=C2=A0 =C2=A0 pWnd-&gt;GetWindowRect(&amp;rect);<br />=C2=A0 =
=C2=A0 ScreenToClient(&amp;rect);<br />=C2=A0 =C2=A0 InvalidateRect(&amp;re=
ct, TRUE);<br /></div><div>]]]</div></div></blockquote><div><br /></div><di=
v>why not just use</div><div>GetDlgItem(IDC_PROPVALUE)-&gt;Invalidate();</d=
iv><div>?=C2=A0</div><div><br /></div><div>maybe there's something we could=
 do differently in=C2=A0CTheme::MainSubclassProc ? I can't reproduce this h=
ere, not even in a VM. So I won't be of much help :(</div><div>=C2=A0</div>=
</div>

<p></p>

-- <br />
You received this message because you are subscribed to the Google Groups &=
quot;TortoiseSVN-dev&quot; group.<br />
To unsubscribe from this group and stop receiving emails from it, send an e=
mail to <a href=3D"mailto:[email protected]">tor=
[email protected]</a>.<br />
To view this discussion visit <a href=3D"https://groups.google.com/d/msgid/=
tortoisesvn-dev/0384aa32-ff66-4847-99a5-add7fa202fben%40googlegroups.com?ut=
m_medium=3Demail&utm_source=3Dfooter">https://groups.google.com/d/msgid/tor=
toisesvn-dev/0384aa32-ff66-4847-99a5-add7fa202fben%40googlegroups.com</a>.<=
br />

------=_Part_11631_1767855625.1731620533424--

------=_Part_11630_627128367.1731620533424--