Re: 1.2 bug? (plus a SRPM bug or two)

Bob Friesenhahn wrote:
> On Thu, 1 May 2008, Don MacAskill wrote:
>>
>> Just compiled 1.2 from the tarball (after the 1.2-1 SRPM wouldn't build
>> - more on that in a second), and a basic JPEG resize seems to wipe out
>> the EXIF data:
>>
>> gm mogrify -resize 1600x1200 filename.jpg
>>
>> The IPTC, APP1, and ICC profiles are all still intact, properly, but
>> EXIF is gone.  I've tried multiple JPEGs from multiple cameras.
> 
> This is because GraphicsMagick still does not save EXIF profiles. Simply 
> saving the EXIF profile "as is" is not the right thing to do. Certain 
> things should be edited/removed prior to saving the profile.
> 
> I have heard a number of complaints about this, so obviously it is 
> something that needs to be fixed.
> 

Hmm, dang, that's a real problem for us.  Our customers expect the EXIF 
to remain intact, unchanged.

Is there a reason I can't re-add it using "-profile" though?  That seems 
like a sane workaround in the event you're totally opposed to preserving 
the EXIF data - I can just export it and then re-import it, as messy as 
that sounds to me.  But if I try, it doesn't get re-added....


>> Also, the SRPM fails to build properly because it's looking for 'NEWS',
>> which doesn't exist.  Changing the spec file to look for 'NEWS.txt' does
>> properly build an RPM.
> 
> Thanks.  That is an easy fix.
> 
>> Finally, installing said RPM gives a 'No decode delegate for this image
>> format (filename.jpg).' error even on a JPEG, despite seeing in the
>> configure log that all the JPEG stuff was found.  A vanilla 'configure;
> 
> That is definitely cause for concern.  The spec file requests a 
> "modules" build.  GraphicsMagick 1.2 is using libtool 2.2.X with a new 
> libltdl.  If a suitable (at least assumed so) libltdl is already 
> installed, it will be used.  Perhaps the installed libltdl is not 
> actually suitable?  If adding the configure option --with-included-ltdl 
> solves the problem, then that indicates an issue with the already 
> installed libltdl
> 
> Are you able and willing to help resolve this issue?  I have attached an 
> updated GraphicsMagick.spec.in which was just committed to CVS.  It 
> fixes the naming of the NEWS file as well as requests running libtool in 
> its normal "verbose" mode so that more data can be available to resolve 
> the problem.  A build log is appreciated.  The most effective way to 
> diagnose the problem is to perform the same build "by hand" in order to 
> investigate what is going on.
> 

Yep, I'm willing to help resolve it.  I'll try to get some time today, 
but it's already looking like one-of-those-days, so we'll see.

I'm not sure what you mean by "by hand" - do you just mean manually 
compile GM using the configure/build parameters inside the spec file? 
Or something else?

> Module loading may be diagnosed via
> 
> MAGICK_DEBUG=configure gm convert -list formats
> 
> You can use
> 
> MAGICK_DEBUG=configure,coder
> 
> in front of any GM command in order to see how it configures itself, 
> loads modules, and what the encode/decode support is doing.  There is 
> also a -debug option you can use but this misses logging a bit of 
> initialization code.
> 

Ok, cool.  I'll let you know what I find.

Thanks,

Don




-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone