GraphicsMagick: ReadXPMImage(): Fix Coverity issue 381863 "Contr...

GraphicsMagick Commits <[email protected]>
Newsgroups gmane.comp.video.graphicsmagick.cvs
Message-ID <mailman.14868.1667942961.1567.graphicsmagick-commit@lists.sourceforge.net>
changeset a666dd42bc2c in /hg/GraphicsMagick
details: http://hg.GraphicsMagick.org/hg/GraphicsMagick?cmd=changeset;node=a666dd42bc2c
summary: ReadXPMImage(): Fix Coverity issue 381863 "Control flow issues (DEADCODE)"

diffstat:

 ChangeLog          |  3 +++
 coders/xpm.c       |  2 --
 www/Changelog.html |  4 ++++
 3 files changed, 7 insertions(+), 2 deletions(-)

diffs (38 lines):

diff -r db3139170761 -r a666dd42bc2c ChangeLog
--- a/ChangeLog	Tue Nov 08 15:25:14 2022 -0600
+++ b/ChangeLog	Tue Nov 08 15:29:11 2022 -0600
@@ -1,5 +1,8 @@
 2022-11-08  Bob Friesenhahn  <[email protected]>
 
+	* coders/xpm.c (ReadXPMImage): Fix Coverity issue 381862
+	"(DEADCODE)".
+
 	* magick/operator.c (QuantumGammaCB): Fix Coverity issue 381863
 	"Control flow issues (DEADCODE)".
 
diff -r db3139170761 -r a666dd42bc2c coders/xpm.c
--- a/coders/xpm.c	Tue Nov 08 15:25:14 2022 -0600
+++ b/coders/xpm.c	Tue Nov 08 15:29:11 2022 -0600
@@ -643,8 +643,6 @@
               r++;
               p+=width;
             }
-          if (MagickFail == status)
-            break;
           if (!SyncImagePixelsEx(image,exception))
             break;
         }
diff -r db3139170761 -r a666dd42bc2c www/Changelog.html
--- a/www/Changelog.html	Tue Nov 08 15:25:14 2022 -0600
+++ b/www/Changelog.html	Tue Nov 08 15:29:11 2022 -0600
@@ -40,6 +40,10 @@
 <p>2022-11-08  Bob Friesenhahn  &lt;<a class="reference external" href="mailto:bfriesen&#37;&#52;&#48;simple&#46;dallas&#46;tx&#46;us">bfriesen<span>&#64;</span>simple<span>&#46;</span>dallas<span>&#46;</span>tx<span>&#46;</span>us</a>&gt;</p>
 <blockquote>
 <ul class="simple">
+<li><p>coders/xpm.c (ReadXPMImage): Fix Coverity issue 381862
+&quot;(DEADCODE)&quot;.</p></li>
+<li><p>magick/operator.c (QuantumGammaCB): Fix Coverity issue 381863
+&quot;Control flow issues (DEADCODE)&quot;.</p></li>
 <li><p>coders/png.c (ReadOnePNGImage): Fix Coverity issue 381864
 &quot;BAD_SHIFT&quot;.</p></li>
 <li><p>magick/operator.c (QuantumDepthCB): Fix Coverity issue 381867
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.