GraphicsMagick: QuantumLogCB() Fix Coverity issue 381861 "Contro...

GraphicsMagick Commits <[email protected]>
Newsgroups gmane.comp.video.graphicsmagick.cvs
Message-ID <mailman.14671.1667943102.1459.graphicsmagick-commit@lists.sourceforge.net>
changeset 0ef485ee4875 in /hg/GraphicsMagick
details: http://hg.GraphicsMagick.org/hg/GraphicsMagick?cmd=changeset;node=0ef485ee4875
summary: QuantumLogCB() Fix Coverity issue 381861 "Control flow issues (DEADCODE)"

diffstat:

 ChangeLog          |  3 +++
 magick/operator.c  |  6 +++---
 www/Changelog.html |  2 ++
 3 files changed, 8 insertions(+), 3 deletions(-)

diffs (43 lines):

diff -r a666dd42bc2c -r 0ef485ee4875 ChangeLog
--- a/ChangeLog	Tue Nov 08 15:29:11 2022 -0600
+++ b/ChangeLog	Tue Nov 08 15:31:30 2022 -0600
@@ -1,5 +1,8 @@
 2022-11-08  Bob Friesenhahn  <[email protected]>
 
+	* magick/operator.c (QuantumLogCB): Fix Coverity issue 381861
+	"Control flow issues (DEADCODE)".
+
 	* coders/xpm.c (ReadXPMImage): Fix Coverity issue 381862
 	"(DEADCODE)".
 
diff -r a666dd42bc2c -r 0ef485ee4875 magick/operator.c
--- a/magick/operator.c	Tue Nov 08 15:29:11 2022 -0600
+++ b/magick/operator.c	Tue Nov 08 15:31:30 2022 -0600
@@ -954,12 +954,12 @@
             }
         }
     }
+  if (MagickFail == status)
+    return status;
 #else
   ARG_NOT_USED(*mutable_context);
+  ARG_NOT_USED(status);
 #endif
-  if (MagickFail == status)
-    return status;
-
   switch (immutable_context->channel)
     {
     case RedChannel:
diff -r a666dd42bc2c -r 0ef485ee4875 www/Changelog.html
--- a/www/Changelog.html	Tue Nov 08 15:29:11 2022 -0600
+++ b/www/Changelog.html	Tue Nov 08 15:31:30 2022 -0600
@@ -40,6 +40,8 @@
 <p>2022-11-08  Bob Friesenhahn  &lt;<a class="reference external" href="mailto:bfriesen&#37;&#52;&#48;simple&#46;dallas&#46;tx&#46;us">bfriesen<span>&#64;</span>simple<span>&#46;</span>dallas<span>&#46;</span>tx<span>&#46;</span>us</a>&gt;</p>
 <blockquote>
 <ul class="simple">
+<li><p>magick/operator.c (QuantumLogCB): Fix Coverity issue 381861
+&quot;Control flow issues (DEADCODE)&quot;.</p></li>
 <li><p>coders/xpm.c (ReadXPMImage): Fix Coverity issue 381862
 &quot;(DEADCODE)&quot;.</p></li>
 <li><p>magick/operator.c (QuantumGammaCB): Fix Coverity issue 381863
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.