Re: [PATCH] MNG detection fails with libjpeg-turbo

The Wanderer <[email protected]> Fri, 22 Dec 2017 20:00:07 -0500
Newsgroups	gmane.comp.video.mplayer.devel
Organization	This space intentionally left blank.
Message-ID	<[email protected]>
On 2017-12-17 at 19:20, The Wanderer wrote:

> On 2017-12-17 at 16:55, Alexander Strasser wrote:

>> There are only 2 choices for libmng, document that it is always
>> needed to include stdio.h before libmng.h or to include it
>> themselves.
> 
> I hadn't even considered that aspect, but you're right.
> 
>> And indeed I think they decided to do the latter. Though for some
>> unknown reason, this was removed from the Debian package in a
>> seemingly unrelated custom patch that is applied to libmng in the
>> build process of the libmng debian package:
>> 
>> https://sources.debian.org/src/libmng/1.0.10+dfsg-3.1/debian/patches/support-lcms2.patch/

I agree that that line of the patch looks buggy.

>>  So I believe MPlayer mng support is working fine when using
>> vanilla libmng or maybe even on all distributions not re-using the
>> debian package.
>> 
>> This is why I do not really like to apply the patch anymore :( It
>> is like programming for the Debian version of libmng, when they are
>> actually the ones that got it wrong. This should be reported to a
>> person or a mailing list at Debian.
> 
> Apparently it's already been reported, in 2015, as Debian bug
> #798781.
> 
> That bug was closed as "fixed in new upstream version" back in 2016,
> but the new version in question is apparently *still* in
> experimental (rather than unstable) after all this time.

Judging by

https://tracker.debian.org/pkg/libmng

and some of the things linked from there, it looks like the former
maintainer of the Debian package for libmng orphaned that package
shortly *before* uploading this fixed version to experimental, and the
package hasn't been touched since.

What's really needed is a new maintainer for that package, but I'm not
sure I can volunteer in that role and expect to be able to hold it up
properly.

If it would be accepted, a NMU to update the package to current
standards (and current upstream, if any, which would involve updating
any still-applicable patches) and upload it to unstable would probably
be enough, but I'm not sure that would be considered appropriate in the
absence of anyone to maintain the package.

-- 
   The Wanderer

The reasonable man adapts himself to the world; the unreasonable one
persists in trying to adapt the world to himself. Therefore all
progress depends on the unreasonable man.         -- George Bernard Shaw

_______________________________________________
MPlayer-dev-eng mailing list
[email protected]
https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng
signature.asc (application/pgp-signature, 833 B)