Re: Some patches...

Mon Jul 08 2002, Martin Piskernig wrote:
> Hi list!
> 
> the attached patch:
> * renames GetCurrentDomain and GetCurrentLocation in dvdcontrol.h to the 
> standard naming scheme (was there any reason to have the DVD prefix cut off 
> there?)
Temporary brain meltdown :)

> * adds a function DVDGetCurrentTitleTime() to the dvdcontrol API, I think 
> you can guess what it does ;-)

Yes, but I'm not sure why you whant to add it.
The GetCurrentLocation, that you obviously looked at, should give you the
time. (It doesn't actually work as inteded though... ) and the lack of
documentation migh not have made that clear.

> * implements the DVDTimeSearch() function in dvdcontrol, but not fully at
> the moment.. it only seeks to the correct chapter the timecode is located
> at, but not to the exact time position in the chapter... this should be
> relatively  trivial to add for those who know where to look in libdvdread :-)
> 
There are unfortunatly several methods.  Onem, the simplest, only works
for titles that allow seeking.  I.e. the ones that have entries in the
time map table.  More advanced coded is necessary to enabvle seeking in
menu sequences.

> I think, with the latter two changes, implementing a slider should 
> be possible in a GUI.  
> 
Yeah, want to set up something so you can get time events rather than
having to ask for the all the time.
Can do it like this temporarily though.

-- 
Håkan Hjort