Re: [PATCH] Use requested win32 dvd-adapter

Thanks, will do, I've just now registered for an account at code.videolan.org

This is all very confusing.. finding out the correct procedure to do anything..
I read and read and cross checked, and still got it wrong!.

Thanks.
________________________________
From: vlc-devel <[email protected]> on behalf of [email protected] <[email protected]>
Sent: Tuesday, 13 February 2024 12:28 AM
To: Mailing list for VLC media player developers <[email protected]>
Subject: Re: [vlc-devel] [PATCH] Use requested win32 dvd-adapter

On 13 Feb 2024, at 1:06, Craig Huggins wrote:

> Use requested win32 dvd-adapter by looking for passed argument more thoroughly, matching linux dvb-adapter lookup.
>
> I've tested this against vlc-3.0 git branch, and the issue remains in 4.0 development branch.
>
> Enables using multiple instances of vlc each capturing their own dvb-adapter,
> or a single libvlc instance capturing from multiple adapters via multiple player instances
>

Hi, thanks for the patch.

If possible please submit it on https://code.videolan.org/videolan/vlc/

Also there is a typo in the commit message, it says dvd-adapter but it should be dvb-adapter.

> ---
>  modules/access/dtv/bdagraph.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/modules/access/dtv/bdagraph.cpp b/modules/access/dtv/bdagraph.cpp
> index b9b28cfac1..c6b26f926a 100644
> --- a/modules/access/dtv/bdagraph.cpp
> +++ b/modules/access/dtv/bdagraph.cpp
> @@ -2042,7 +2042,7 @@ HRESULT BDAGraph::Check( REFCLSID clsid_this_network_type )
>       * available, so return with an error. */
>
>      long l_adapter = -1;
> -    l_adapter = var_GetInteger( p_access, "dvb-adapter" );
> +    l_adapter = var_InheritInteger( p_access, "dvb-adapter" );
>      if( l_tuner_used < 0 && l_adapter >= 0 )
>          l_tuner_used = l_adapter - 1;
>
> --
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
_______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
https://mailman.videolan.org/listinfo/vlc-devel

_______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
https://mailman.videolan.org/listinfo/vlc-devel