[PATCH] http: improve FIXME comment for digest authentication handling

--===============5053446677416045681==
Content-Type: multipart/alternative; boundary="000000000000792027064f8fad00"

--000000000000792027064f8fad00
Content-Type: text/plain; charset="UTF-8"

Hi,

This patch improves a FIXME comment in the Digest authentication handling
code.

The updated comment clarifies that repeated Digest authentication headers
are not currently handled, making the limitation more explicit for future
contributors.

No functional changes are introduced.

Thanks,
Manjeet

From 62816b609e62eb9bd0abbbd58aae647fd7e09e5a Mon Sep 17 00:00:00 2001
From: Manjeet Yaduvanshi <[email protected]>
Date: Thu, 9 Apr 2026 23:32:57 +0530
Subject: [PATCH] http: improve FIXME comment for digest authentication
 handling

---
 src/network/http_auth.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/network/http_auth.c b/src/network/http_auth.c
index 572db699d6..3f27bbe045 100644
--- a/src/network/http_auth.c
+++ b/src/network/http_auth.c
@@ -234,8 +234,10 @@ void vlc_http_auth_ParseWwwAuthenticateHeader(
         msg_Dbg( p_this, "Using Digest Access Authentication" );

         if ( p_auth->psz_nonce )
-            /* FIXME */
+        {
+            /* FIXME: Handle repeated Digest authentication headers properly */
             return;
+        }

         psz_header += sizeof( psz_digest_prefix ) - 1;
         p_auth->psz_realm = AuthGetParam( psz_header, "realm" );
-- 
2.53.0.windows.1

--000000000000792027064f8fad00
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"auto">Hi,<br><br>This patch improves a FIXME comment in the Dig=
est authentication handling code.<br><br>The updated comment clarifies that=
 repeated Digest authentication headers are not currently handled, making t=
he limitation more explicit for future contributors.<br><br>No functional c=
hanges are introduced.<br><br>Thanks,<br>Manjeet<br><br><div dir=3D"auto"><=
pre style=3D"text-wrap-mode: wrap;">From 62816b609e62eb9bd0abbbd58aae647fd7=
e09e5a Mon Sep 17 00:00:00 2001
From: Manjeet Yaduvanshi &lt;<a href=3D"mailto:[email protected]=
om">[email protected]</a>&gt;
Date: Thu, 9 Apr 2026 23:32:57 +0530
Subject: [PATCH] http: improve FIXME comment for digest authentication
 handling

---
 src/network/http_auth.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/network/http_auth.c b/src/network/http_auth.c
index 572db699d6..3f27bbe045 100644
--- a/src/network/http_auth.c
+++ b/src/network/http_auth.c
@@ -234,8 +234,10 @@ void vlc_http_auth_ParseWwwAuthenticateHeader(
         msg_Dbg( p_this, &quot;Using Digest Access Authentication&quot; );
=20
         if ( p_auth-&gt;psz_nonce )
-            /* FIXME */
+        {
+            /* FIXME: Handle repeated Digest authentication headers proper=
ly */
             return;
+        }
=20
         psz_header +=3D sizeof( psz_digest_prefix ) - 1;
         p_auth-&gt;psz_realm =3D AuthGetParam( psz_header, &quot;realm&quo=
t; );
--=20
2.53.0.windows.1
</pre><br></div></div>

--000000000000792027064f8fad00--

--===============5053446677416045681==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
https://mailman.videolan.org/listinfo/vlc-devel

--===============5053446677416045681==--