[PATCH] input: improve TODO comment for function naming clarity

MANJEET YADUVANSHI <[email protected]> Sat, 18 Apr 2026 15:36:32 +0530
Newsgroups gmane.comp.video.videolan.vlc.devel
Message-ID <CAJP-peQvNPg6-9rg5xj68mVGYBq8zSxCr5kp3GosksNtgdjf2Q@mail.gmail.com>
--===============7842029924154531909==
Content-Type: multipart/alternative; boundary="000000000000fd5fb5064fb93869"

--000000000000fd5fb5064fb93869
Content-Type: text/plain; charset="UTF-8"

Hi,

This patch improves a TODO comment related to function naming.

The updated comment makes it clearer that the function name should better
describe its behavior.

No functional changes are introduced.

Thanks,
Manjeet

From 6a957b0379aac0dfc0dd10e805e2d084b7e026c5 Mon Sep 17 00:00:00 2001
From: Manjeet Yaduvanshi <[email protected]>
Date: Fri, 3 Apr 2026 16:01:56 +0530
Subject: [PATCH] input: improve TODO comment for function naming clarity

---
 src/input/input.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/input/input.c b/src/input/input.c
index 6cd40c5fb7..7d8b961fc7 100644
--- a/src/input/input.c
+++ b/src/input/input.c
@@ -112,7 +112,7 @@ static void AppendAttachment(input_thread_t* p_input,
 static int input_SlaveSourceAdd( input_thread_t *, enum slave_type,
                                  const char *, unsigned );
 static char *input_SubtitleFile2Uri( input_thread_t *, const char * );
-static void input_ChangeState( input_thread_t *p_input, int i_state,
vlc_tick_t ); /* TODO fix name */
+static void input_ChangeState( input_thread_t *p_input, int i_state,
vlc_tick_t ); /* TODO: Rename this function to better describe its
behaviour */

 /**
  * Start a input_thread_t created by input_Create.
-- 
2.53.0.windows.1

--000000000000fd5fb5064fb93869
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"auto">Hi,<br><br>This patch improves a TODO comment related to =
function naming.<br><br>The updated comment makes it clearer that the funct=
ion name should better describe its behavior.<br><br>No functional changes =
are introduced.<br><br>Thanks,<br>Manjeet<br><br><pre style=3D"text-wrap-mo=
de: wrap;">From 6a957b0379aac0dfc0dd10e805e2d084b7e026c5 Mon Sep 17 00:00:0=
0 2001
From: Manjeet Yaduvanshi &lt;<a href=3D"mailto:[email protected]=
om">[email protected]</a>&gt;
Date: Fri, 3 Apr 2026 16:01:56 +0530
Subject: [PATCH] input: improve TODO comment for function naming clarity

---
 src/input/input.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/input/input.c b/src/input/input.c
index 6cd40c5fb7..7d8b961fc7 100644
--- a/src/input/input.c
+++ b/src/input/input.c
@@ -112,7 +112,7 @@ static void AppendAttachment(input_thread_t* p_input,
 static int input_SlaveSourceAdd( input_thread_t *, enum slave_type,
                                  const char *, unsigned );
 static char *input_SubtitleFile2Uri( input_thread_t *, const char * );
-static void input_ChangeState( input_thread_t *p_input, int i_state, vlc_t=
ick_t ); /* TODO fix name */
+static void input_ChangeState( input_thread_t *p_input, int i_state, vlc_t=
ick_t ); /* TODO: Rename this function to better describe its behaviour */
=20
 /**
  * Start a input_thread_t created by input_Create.
--=20
2.53.0.windows.1
</pre><br></div>

--000000000000fd5fb5064fb93869--

--===============7842029924154531909==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
https://mailman.videolan.org/listinfo/vlc-devel

--===============7842029924154531909==--