Re: Regression in xine-ui-0.99.7 : Open File doesn't work

Hello!

>   OK people, trying to subscribe to your -bugs doesn't work
> (it doesn't mail the authentication, and it looks as if the
> list might be defunct), and posting on -users got no response,
> so now I'm here on -devel with a crazy patch to work around a
> regression.

Hehe how nice to hear from somebody who shares my style of talking
(have you ever read the Amiga Guru Book?). :-)

> Eventually I discovered that trying to open a file with
> the right mouse button and Open -> File wasn't working.

Well, all you needed to do is to hit the >| NEXT button or to
open the playlist editor, and you would know where all your
attempts went.

The real reason is turning the XINE logo screen from a motion
video into a plain still image. Unlike AV, images are meant to
play always and forever to let an average living room user zap
through his photo album.

Your patch perhaps breaks intentional playlist appending, and
it will fail as soon as someone decides to use a video logo
again.

Maybe it is a better idea to make an exception for just the
logo if a still image.

[xine-ui_open_file.diff]
open user file immediately when only logo is playing

> This is on x86_64 linuxfromscratch, and I first noticed at the
> end of my current desktop build - LFS-7.3
> (still gcc-4.7 series), everything else generally
> current released versions.
>
> As I noted on -users, on LFS we have current autotools.  To run
> autogen.sh I need to do
>   sed -i 's/AM_CONFIG_HEADER/AC_CONFIG_HEADERS/g' configure.ac

Dont say that too loud - they might "fix" it by breaking build
on my old box...

Torsten

------------------------------------------------------------------------------
Precog is a next-generation analytics platform capable of advanced
analytics on semi-structured data. The platform includes APIs for building
apps and a phenomenal toolset for data science. Developers can use
our toolset for easy data analysis & visualization. Get a free account!
http://www2.precog.com/precogplatform/slashdotnewsletter

_______________________________________________
xine-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/xine-devel

--- xine-ui-20130319/src/xitk/actions.c	2013-04-15 11:41:39.000000000 +0200
+++ xine-ui-20130319/src/xitk/actions.c	2013-04-15 11:41:39.000000000 +0200
@@ -2148,7 +2148,8 @@ static void fileselector_callback(filebr
 
     /* If an MRL is not being played, select the first file appended. If in "smart mode" start
        playing the entry.  If a an MRL is currently being played, let it continue normally */
-    if((first != gGui->playlist.num) && (xine_get_status(gGui->stream) == XINE_STATUS_STOP)) {
+    if((first != gGui->playlist.num) &&
+      (gGui->logo_mode || (xine_get_status(gGui->stream) == XINE_STATUS_STOP))) {
       gGui->playlist.cur = first;
       if(gGui->smart_mode) {
         gui_set_current_mmk(mediamark_get_current_mmk());