Re: [Patch] Add src/video_dec/group_raw.h in the tarball

Torsten Jager <[email protected]> Thu, 10 Nov 2016 17:30:50 +0100
Newsgroups gmane.comp.video.xine.devel
Message-ID <[email protected]>
Hi,

> I've seen xine-lib 1.2.7 was tagged a couple weeks ago, however the
> tarball was not made available, so I built my own. I then found out that
> it's missing src/video_dec/group_raw.h. Attached patch fixes this issue.
> I still can't build from the tarball because of an unrelated issue, I'll
> send a patch or at least make a bug report once I've looked into it a
> bit more.
>
> Regards,
> Xavier

Thank you :))

[Part1]

This is actually the first time I ever tried "make dist". Blimey.

As far as I understand that:

   foo_SOURCES = <run compiler and build .o once for each of these>

Putting group_raw.h here would create an unneeded and possibly
conflicting .o file.

   EXTRA_DIST = <these shall not build individually, but nevertheless
     show up in tarball>

Maybe a better place?

   noinst_HEADERS = <these are #included locally, and shall not
     be installed to system include dir>

Yes that sounds good. See my upload.
In fact, I already did 2 more group headers this way before.
For src/video_dec/Makefile.am, however, there was no such line
in there previously, and I missed that one.
Now I can build from make dist output here.

Another question: is there some make target that includes the
./autogen.sh call, to set up a release type tarball?

[Part2]

I bumped revision because I added 8 new functions to libxine,
and I thought this does require a tag.
I'm not really a project admin. I dont know exactly what a hg tag
is good for. I also dont have write permission outside hg.debian.org.
Real admin seems no longer listening.
Do we need to set another tag when fixed?
And why does v1.2.7 install plugins to the 2.6 dir?

Speaking of admin: You have your own domain... Wow :-)

[Part3]

Again, thank you. You just answered my 18 month question:
Does anybody still care about xine ?
Does it make sense uploading any more ?
Or are the days of xine (or maybe Linux machines in general)
counted?

Torsten


------------------------------------------------------------------------------
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today. http://sdm.link/xeonphi