Re: [Patch] Add src/video_dec/group_raw.h in the tarball

Hi Torsten,

On 10/11/2016 17:30, Torsten Jager wrote:
> Hi,
> 
>> I've seen xine-lib 1.2.7 was tagged a couple weeks ago, however the
>> tarball was not made available, so I built my own. I then found out that
>> it's missing src/video_dec/group_raw.h. Attached patch fixes this issue.
>> I still can't build from the tarball because of an unrelated issue, I'll
>> send a patch or at least make a bug report once I've looked into it a
>> bit more.
>>
>> Regards,
>> Xavier
> 
> Thank you :))
> 
> [Part1]
> 
> This is actually the first time I ever tried "make dist". Blimey.
> 
> As far as I understand that:
> 
>    foo_SOURCES = <run compiler and build .o once for each of these>
> 
> Putting group_raw.h here would create an unneeded and possibly
> conflicting .o file.
> 
>    EXTRA_DIST = <these shall not build individually, but nevertheless
>      show up in tarball>
> 
> Maybe a better place?
> 
>    noinst_HEADERS = <these are #included locally, and shall not
>      be installed to system include dir>
> 
> Yes that sounds good. See my upload.
> In fact, I already did 2 more group headers this way before.
> For src/video_dec/Makefile.am, however, there was no such line
> in there previously, and I missed that one.
> Now I can build from make dist output here.
> 
Thank you :-)

> Another question: is there some make target that includes the
> ./autogen.sh call, to set up a release type tarball?
> 
I don't know what the release process for xine-lib is. Probably Darren
Salt would know.
I've tried to ping him about the tarball a couple times on IRC, but no
luck so far... I was also requesting a new release before that, as 1.2.6
is/was 2 years old and you (and others) have added quite some good stuff
in-between. It's really nice you tagged a release, I wouldn't have
noticed the tarball generation issue w/o it.

> [Part2]
> 
> I bumped revision because I added 8 new functions to libxine,
> and I thought this does require a tag.
> I'm not really a project admin. I dont know exactly what a hg tag
> is good for. I also dont have write permission outside hg.debian.org.
> Real admin seems no longer listening.

A tag is useful when you want to mark some particular point in
development, like a release.

> Do we need to set another tag when fixed?

Possibly, as it's not possible to build from a tarball released from the
xine-lib 1.2.7 tag.


> And why does v1.2.7 install plugins to the 2.6 dir?
> 
Plugin abi change ?

> Speaking of admin: You have your own domain... Wow :-)
> 
Started as a playground, grown up into lot of self-hosted services that
keep me (somewhat) out of Google and others privacy invading tentacles ;-)

> [Part3]
> 
> Again, thank you. You just answered my 18 month question:
> Does anybody still care about xine ?
> Does it make sense uploading any more ?
> Or are the days of xine (or maybe Linux machines in general)
> counted?
> 
I still very much care about xine-lib. Actually I'm maintaining it for a
3rd party Fedora repository, RPM Fusion, as ffmpeg is not allowed in
Fedora proper because of software patent issues.

Speaking of this, there are currently 2 patches needed for the Fedora
package, it would be nice if they can be reviewed and pushed.
One is here : [1]
The second one came from this bug report [2], and is attached to this mail.

Also, there might be something more to fix in the tarball generation.
The second problem I alluded to in my first email was some missing files
in the tarball for ffmpeg, namely mkcodeclist.pl, avcodec_video.list and
xine_video.list. I generated a tarball that contained them after
installing ffmpeg-devel, but I think they should be unconditionally
added when generating the tarball.
I guess the changeset that brought this "regression" is [3], especially
the part that modifies src/combined/ffmpeg/Makefile.am

[1] https://bugs.xine-project.org/show_bug.cgi?id=573
[2] http://bugzilla.redhat.com/477226
[3] https://anonscm.debian.org/hg/xine-lib/xine-lib-1.2/rev/ad6811727a11

Regards,
Xavier

------------------------------------------------------------------------------
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today. http://sdm.link/xeonphi

_______________________________________________
xine-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/xine-devel

diff -up xine-lib-1.1.16.2/misc/xine-config.in.multilib xine-lib-1.1.16.2/misc/xine-config.in
--- xine-lib-1.1.16.2/misc/xine-config.in.multilib	2008-06-25 08:04:09.000000000 -0500
+++ xine-lib-1.1.16.2/misc/xine-config.in	2009-02-20 07:34:27.000000000 -0600
@@ -6,12 +6,6 @@ unset prefix
 unset exec_prefix
 unset args
 
-PKG_CONFIG_PATH="`cat <<'EOF'
-@XINE_PKGCONFIG_DIR@
-EOF
-`${PKG_CONFIG_PATH:+:}$PKG_CONFIG_PATH"
-export PKG_CONFIG_PATH
-
 usage()
 {
 	cat <<EOF