Lots of deprecation warnings when running automake

Hi,

automake is giving a lot of warnings on Fedora 25 and probably others. Here's some output trimmed to remove the duplicates :

1/
configure.ac:225: warning: The 'AM_PROG_MKDIR_P' macro is deprecated, and its use is discouraged.
configure.ac:225: You should use the Autoconf-provided 'AC_PROG_MKDIR_P' macro instead,
configure.ac:225: and use '$(MKDIR_P)' instead of '$(mkdir_p)'in your Makefile.am files.

2/
configure.ac:1166: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')

3/
src/input/Makefile.am:110: warning: source file '../demuxers/asfheader.c' is in a subdirectory,
src/input/Makefile.am:110: but option 'subdir-objects' is disabled
automake: warning: possible forward-incompatibility.
automake: At least a source file is in a subdirectory, but the 'subdir-objects'
automake: automake option hasn't been enabled.  For now, the corresponding output
automake: object file(s) will be placed in the top-level directory.  However,
automake: this behaviour will change in future Automake versions: they will
automake: unconditionally cause object files to be placed in the same subdirectory
automake: of the corresponding sources.
automake: You are advised to start using 'subdir-objects' option throughout your
automake: project, to avoid future incompatibilities.


I'm attaching a patch for 2/, I'll try and look at the 2 others, but feel free to beat me to it.

Additionally, some possible portability issues are also showing up :

misc/Makefile.quiet:1: warning: ':='-style assignments are not portable
misc/Makefile.quiet:1: warning: if $(findstring GNU,$(shell $(MAKE: non-POSIX variable name
misc/Makefile.quiet:1: (probably a GNU make extension)

contrib/Makefile.am:18: warning: shell cd @srcdir@; pwd: non-POSIX variable name
contrib/Makefile.am:18: (probably a GNU make extension)

Regards,
Xavier

------------------------------------------------------------------------------

_______________________________________________
xine-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/xine-devel

# HG changeset patch
# User Xavier Bachelot <[email protected]>
# Date 1479894825 -3600
#      Wed Nov 23 10:53:45 2016 +0100
# Node ID 5cd27242b4c8014a89524805a7a737b1f3ce67b6
# Parent  e81e9663b4f7481afa914a3ba864444a0a7f9a16
Prevent deprecation warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')

diff -r e81e9663b4f7 -r 5cd27242b4c8 configure.ac
--- a/configure.ac	Tue Nov 22 11:17:57 2016 +0200
+++ b/configure.ac	Wed Nov 23 10:53:45 2016 +0100
@@ -1163,7 +1163,7 @@
 dnl ---------------------------------------------
 
 INCLUDES='-I$(top_srcdir) -I$(top_builddir)/include -I$(top_srcdir)/include -I$(top_srcdir)/src -I$(top_builddir)/src/xine-engine -I$(top_srcdir)/src/xine-engine -I$(top_srcdir)/src/xine-utils $(INTLDIR) -I$(top_builddir)/src/input -I$(top_srcdir)/src/input $(WIN32_INCLUDES) -I$(top_builddir)/lib -I$(top_srcdir)/lib'
-AC_SUBST(INCLUDES)
+AC_SUBST(AM_CPPFLAGS)
 
 dnl We check for warnings here rather than with optimisations since we
 dnl want them to be _always_ enabled, to make sure the code is sane