Re: _x_flags symbol disappered without bumping SONAME

ke, 2017-11-15 kello 17:40 +0100, Mattia Rizzolo kirjoitti:
> Hello everybody,
> 
> so I took upon myself the duty of upgrading xine-lib to 1.2.8 in
> Debian,
> where it's stuck on 1.2.6.  It felt akward asking for that weird x32
> port without having a new enough base here.
> 
> I think it's pretty good to go, but I noticed that the _x_flags
> symbol
> has been removed.  Grepping around the diff between 1.2.6 and 1.2.8 I
> see several references to it with comments like
>     FIXME-ABI Global variable. Done this way for ABI & API reasons...
> that makes me understand that you understand you had to keep it until
> the next ABI break, but for some reason you removed it nonetheless.

I think that comment means the variable could not be added to "proper"
place until next minor bump. It was added at the same time as the
variable itself.

> This seems to have happened in the changeset 12769:01d637e91185.
> 
> Am I missing something and this is not a relevant ABI break, or what?
>
> Note that I didn't check whether the reverse dependencies (within
> Debian, at least) use that symbol.

It was marked as XINE_ENGINE_INTERNAL. So it is not part of external
API/ABI, and should not be used outside of xine-lib.

Anyway, I can't figure out why it was added as externally visible
global variable (not private) in the first place. Maybe I'm missing
something else, the original change was merged from 1.1.x branch. Maybe
it was added this way for extra ABI safety (xine_t size), because of
buggy tools/linkers, or to avoid bumping .so minor version (?). Or
maybe all this was somehow related to debian package update/upgrade
policy, I don't know.

> Thanks in advance.
> 
> -------------------------------------------------------------------
> -----------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> xine-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/xine-devel

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot