Re: _x_flags symbol disappered without bumping SONAME

Mattia Rizzolo <[email protected]> Fri, 17 Nov 2017 17:53:57 +0100
Newsgroups	gmane.comp.video.xine.devel
Message-ID	<[email protected]>
On Fri, Nov 17, 2017 at 01:42:52PM +0200, Petri Hintukainen wrote:
> > Grepping around the diff between 1.2.6 and 1.2.8 I
> > see several references to it with comments like
> >     FIXME-ABI Global variable. Done this way for ABI & API reasons...
> > that makes me understand that you understand you had to keep it until
> > the next ABI break, but for some reason you removed it nonetheless.
> 
> I think that comment means the variable could not be added to "proper"
> place until next minor bump. It was added at the same time as the
> variable itself.

Oh, that makes sense.

> > This seems to have happened in the changeset 12769:01d637e91185.
> > 
> > Am I missing something and this is not a relevant ABI break, or what?
> 
> It was marked as XINE_ENGINE_INTERNAL. So it is not part of external
> API/ABI, and should not be used outside of xine-lib.

I see.  So I'll just ignore it and carry on.  Thank you for confirming!

> Anyway, I can't figure out why it was added as externally visible
> global variable (not private) in the first place. Maybe I'm missing
> something else, the original change was merged from 1.1.x branch. Maybe
> it was added this way for extra ABI safety (xine_t size), because of
> buggy tools/linkers, or to avoid bumping .so minor version (?).

I have no idea either…

> Or maybe all this was somehow related to debian package update/upgrade
> policy, I don't know.

I doubt it…  The debian packaging of this library is very very weird,
but even looking at the changes done to it I don't see anything that
would have an impact on this.

-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
more about me:  https://mapreri.org                             : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

_______________________________________________
xine-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/xine-devel
signature.asc (application/pgp-signature, 833 B)