Fwd: xine-ui bug

---------- Forwarded message ----------
From: Joshua Clayton <[email protected]>
Date: Mon, Apr 2, 2018 at 6:37 AM
Subject: xine-ui bug
To: [email protected], [email protected]


Hi,

glad to see someone working on xine! I hate to see an old friend die.
I found a bug when building with libcaca. Looks to be a simple typo.

x86_64-pc-linux-gnu-gcc  -DCACA  -Wall -D_FILE_OFFSET_BITS=64
-Wpointer-arith -Wnested-externs -Wcast-align -Wchar-subscripts -Wmissing-
declarations -Wmissing-prototypes -march=amdfam10 -O2 -pipe
-fno-stack-protector    -DNDEBUG -Wformat=2 -Wno-format-zero-length -Wmissin
g-format-attribute  -Wmissing-noreturn -Wdisabled-optimization
-Werror-implicit-function-declaration -Wstrict-aliasing=2  -Wl,-O1 -Wl,--
as-needed -o cacaxine cacaxine-main.o -lcaca  -lm -lpthread
../../src/common/libcommon.a -lxine
/usr/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../x86_64-pc-linux-gnu/bin/ld:
cacaxine-main.o: undefined reference to symbol 'dlclose@@
GLIBC_2.2.5'
/lib64/libdl.so.2: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status
make[3]: *** [Makefile:478: cacaxine] Error 1

The patch has been tested on gentoo Linux

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

_______________________________________________
xine-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/xine-devel

diff -r efe11fb1562e configure.ac
--- a/configure.ac	Thu Dec 28 18:08:02 2017 +0200
+++ b/configure.ac	Sun Apr 01 23:00:22 2018 -0600
@@ -374,7 +374,7 @@
    if test "x$with_caca" = "xyes" && test "x$have_caca" = "xno"; then
       AC_MSG_ERROR([CACA support requested, but libcaca 0.99 not found])
    fi
-   if test test "x$have_caca" = "xyes"; then
+   if test "x$have_caca" = "xyes"; then
      AM_DL()
    fi
    AC_COMPILE_IFELSE( [AC_LANG_PROGRAM([[#include <caca.h>