Re: Xvid-devel Digest, Vol 99, Issue 3

----- Original Message ----- 
From: <[email protected]>
To: <[email protected]>
Sent: Friday, May 20, 2011 6:00 PM
Subject: Xvid-devel Digest, Vol 99, Issue 3


> Send Xvid-devel mailing list submissions to
> [email protected]
>
> To subscribe or unsubscribe via the World Wide Web, visit
> http://list.xvid.org/mailman/listinfo/xvid-devel
> or, via email, send a message with subject or body 'help' to
> [email protected]
>
> You can reach the person managing the list at
> [email protected]
>
> When replying, please edit your Subject line so it is more specific
> than "Re: Contents of Xvid-devel digest..."
>
>
> Today's Topics:
>
>   1. Re: make clean may trigger configure run (Michael Militzer)
>   2. Re: make clean may trigger configure run (Fabian Greffrath)
>   3. Re: make clean may trigger configure run (Michael Militzer)
>
>
> ----------------------------------------------------------------------
>
> Message: 1
> Date: Thu, 19 May 2011 12:07:56 +0200
> From: Michael Militzer <[email protected]>
> Subject: Re: [Xvid-devel] make clean may trigger configure run
> To: [email protected]
> Message-ID: <[email protected]>
> Content-Type: text/plain; charset=ISO-8859-1; DelSp="Yes";
> format="flowed"
>
> Hi Fabian,
>
> sounds very reasonable! Patch applied - Thank you.
>
> Best regards,
> Michael
>
>
> Quoting Fabian Greffrath <[email protected]>:
>
>> Hi,
>>
>> currently, if one runs "make clean" (or "make distclean" or "make
>> mrproper") in the build/generic directory in an already distclean'ed
>> source, then this will trigger a configure run, which is IMHO
>> completely useless!
>>
>> The reason for this behaviour is that build/generic/Makefile in line
>> 44 unconditionally includes platform.inc, which has been properly
>> removed by the distclean rule before. The missing platform.inc file
>> then triggers the call to configure via its own rule in line 158.
>>
>> However, since the platform.inc file is completely irrelevant for the
>> clean rules, please consider the attached patch that conditionally
>> includes platform.inc in the Makefile only if it is not called with
>> one of the clean rules.
>>
>> Best Regards,
>> Fabian
>>
>> --
>>
>> --- Debian.orig/xvidcore/build/generic/Makefile
>> +++ Debian/xvidcore/build/generic/Makefile
>> @@ -41,7 +41,9 @@
>>
>> ##############################################################################
>>
>>   include sources.inc
>> +ifeq ($(findstring $(MAKECMDGOALS), clean distclean mrproper),)
>>   include platform.inc
>> +endif
>>
>>   RM = rm -rf
>>
>> _______________________________________________
>> Xvid-devel mailing list
>> [email protected]
>> http://list.xvid.org/mailman/listinfo/xvid-devel
>>
>>
>
>
>
>
>
> ------------------------------
>
> Message: 2
> Date: Fri, 20 May 2011 09:57:39 -0700
> From: Fabian Greffrath <[email protected]>
> Subject: Re: [Xvid-devel] make clean may trigger configure run
> To: [email protected]
> Message-ID: <[email protected]>
> Content-Type: text/plain; charset=ISO-8859-1; format=flowed
>
> Am 19.05.2011 03:07, schrieb Michael Militzer:
>> sounds very reasonable! Patch applied
>
> but not yet commited?
>
>
> ------------------------------
>
> Message: 3
> Date: Fri, 20 May 2011 10:15:03 +0200
> From: Michael Militzer <[email protected]>
> Subject: Re: [Xvid-devel] make clean may trigger configure run
> To: [email protected]
> Message-ID: <[email protected]>
> Content-Type: text/plain; charset=ISO-8859-1; DelSp="Yes";
> format="flowed"
>
> Argh. Seems I committed the patch only to 1.3 branch and not HEAD...
>
> Quoting Fabian Greffrath <[email protected]>:
>
>> Am 19.05.2011 03:07, schrieb Michael Militzer:
>>> sounds very reasonable! Patch applied
>>
>> but not yet commited?
>> _______________________________________________
>> Xvid-devel mailing list
>> [email protected]
>> http://list.xvid.org/mailman/listinfo/xvid-devel
>>
>>
>
>
>
>
>
>
>
>
> ------------------------------
>
> _______________________________________________
> Xvid-devel mailing list
> [email protected]
> http://list.xvid.org/mailman/listinfo/xvid-devel
>
>
> End of Xvid-devel Digest, Vol 99, Issue 3
> *****************************************