Re: ui colors again
Jorge Arellano Cid <[email protected]>
| Newsgroups | gmane.comp.web.dillo.devel |
|---|---|
| Message-ID | <[email protected]> |
On Sun, Dec 30, 2012 at 10:52:37AM -0300, Jorge Arellano Cid wrote:
> On Sun, Dec 30, 2012 at 03:55:34AM +0000, corvid wrote:
> > I wrote:
> > > Today I dug up the old ui colors patch from last September, ripped out the
> > > part that used system colors as defaults that was a problem*, and played
> > > around with it a little. I really like configurable colors, so, since I
> > > haven't heard anyone say anything like feature freeze yet, I'll make another
> > > push for this thing.
> >
> > Committed.
> >
> > - I changed the inactive icon appearance some more.
> > - By default it's using the fltk default colors.
> > - It might be nice to be able to specify the selection color, too.
>
> -1
>
> The default colors or theme are not easy to define, everybody has
> his personal preferences, and there's no single scheme that pleases
> everyone.
>
> The default theme in dillo is kind of a consensus over the
> years. This is, when changes were proposed, the most voted one
> (or less objected) got to be the default (same for the website).
>
> This policy works ok for us and is widely used.
>
> Personally I don't like the change, but I do understand that
> other users, may find it fits better.
>
> So my points are:
>
> * The default colors should not be changed without consensus.
> * The patch should provide a way to keep the previous default
> (i.e. How do I get my colors/pixmaps back?)
>
> PS: WRT the second point, I find the inactive pixmaps too
> "live" for my taste (and thus prefer the pixmaps).
> PS2: Is good to have the input/dialog backgrounds configurable
> but the defaults should be voted.
Just trying to make my points a bit clearer, and after playing
a bit more with the patch:
* +1 to making it configurable (as now)
* +1 to add a dillorc option for the second parameter in
color_average() call (e.g. setting it to 0.1f makes for the
same look as with the handmade pixmaps, so they could be
removed). Adding a parameter for the first one may also
help (although it's not a priority).
* We may suggest some combinations in the web site or dillorc.
This way, the traditional look can easily be set, new ones can
be created (suggested) and a default scheme voted.
Finally, @all, please recieve my best wishes for the new year
that's about to start! ;-)
--
Cheers
Jorge.-