Re: dillo bug#1127

Hi,

On Mon, May 20, 2013 at 02:07:54PM +0200, Urban Lundin wrote:
> Hi Johannes,
> 
> That sounds great if you could attempt to solve this issue!
> We have made a small example in TCL/TK (which you have to install
> first, available through http://www.tcl.tk/)
> 
> We did not try to embed suckless as we could not find a simple
> example inside it.
> 
> 
> Then the example is below.

Thanks for the example. For me it works with the following patch for
dillo:

diff -r ace33e3969af src/xembed.cc
--- a/src/xembed.cc	Sun Apr 28 15:11:03 2013 +0200
+++ b/src/xembed.cc	Mon May 20 19:38:06 2013 +0200
@@ -108,6 +108,7 @@
    createInternal(xid);
    setXembedInfo(1);
    Fl::event_dispatch(event_handler);
+   Fl_Window::show();
 }
 
 void Xembed::createInternal(uint32_t parent) {

Before pushing it to the main repo I need to read
http://standards.freedesktop.org/xembed-spec/xembed-spec-latest.html
a bit more, but to me it seems a reasonable thing to do.
It would be cool, if anyone using the claws mail dillo plugin could
verify that the above patch doesn't break embedding in claws mail.

Cheers,
Johannes