Re: Can't compile Dillo 3.0.3

On Sat, May 18, 2013 at 09:59:18PM +0200, Sebastian Geerken wrote:
> On Sat, May 18, Johannes Hofmann wrote:
> > On Sat, May 18, 2013 at 08:23:34PM +0200, Sebastian Geerken wrote:
> > > On Sat, May 18, Johannes Hofmann wrote:
> > > > On Sat, May 18, 2013 at 02:47:56PM +0200, Sebastian Geerken wrote:
> > > > > [...]
> > > > > 
> > > > > X11 is needed in src/xembed.cc. It seems that on most systems it is
> > > > > linked indirectly, (src/dillo -> libfltk.so -> libX11.so), on others
> > > > > not, so that an additional "-lX11" is necessary. Should we add it
> > > > > generally? It does not harm; we have only to care about other systems
> > > > > than X11.
> > > > 
> > > > Could we check for libX11 in configure and link explicitely against
> > > > it if available but not fail otherwise?
> > > > That way dillo should still compile on OSX.
> > > 
> > > I thought of this. The code is included in "#ifdef X_PROTOCOL", so
> > > making "-lX11" depend on this X_PROTOCOL should be save; however, I've
> > > not found where X_PROTOCOL is defined.
> > 
> > That comes from the fltk headers depending on whether fltk was built
> > with X11 backend or not.
> 
> Do not find it, strange.
> 
> > I don't see how we could get that information at configure time.
> > Maybe some fltk-config option?
> 
> See attached patch for an incomplete implementation. On my system, it
> says "checking whether to link to X11... yes", on OSX it should say
> "... no".

Yes, works ok on OSX:

checking for socklen_t... socklen_t
checking FLTK 1.3... yes
checking whether to link to X11... no

Cheers,
  Johannes