Re: here's 3.0.4.1 RC1

Hi,

I have a fix that works on my system so far:

diff -r 72f0e7ccccc9 src/uicmd.cc
--- a/src/uicmd.cc      Thu Nov 27 19:20:33 2014 +0000
+++ b/src/uicmd.cc      Sun Dec 07 21:20:08 2014 +0100
@@ -551,10 +551,10 @@
    win->box(FL_NO_BOX);
    CustTabs *DilloTabs = new CustTabs(ww, wh, 16);
    win->end();
+   win->resizable(DilloTabs->wizard());
 
    int focus = 1;
    new_bw = UIcmd_tab_new(DilloTabs, old_ui, focus);
-   win->resizable(DilloTabs->wizard());
    win->show();
 
    if (old_bw == NULL && prefs.xpos >= 0 && prefs.ypos >= 0) {


Please give it a try and report back if it breaks anything.

Cheers,
Johannes

PS: The problem was that some code in UIcmd_tab_new() is triggering
Fl_X::sendxjunk() and if at that moment no resizable is set, the 
window get's marked as fixed size.


On Sun, Dec 07, 2014 at 06:36:02PM +0100, Johannes Hofmann wrote:
> On Sat, Dec 06, 2014 at 01:22:06PM +0100, v4hn wrote:
> > On Sat, Dec 06, 2014 at 11:17:36AM +0100, Johannes Hofmann wrote:
> > > I get the same result with dillo-3.0.4.1 and fltk-1.3.3 compiled on Linux
> > > and X11-forwarded to my DragonFly box.
> > > Could someone with a working dillo-3.0.4.1 and fltk-1.3.3 please post the
> > > output of xprop for the dillo window. I get:
> > > 
> > > WM_STATE(WM_STATE):
> > >                 window state: Normal
> > >                 icon window: 0x0
> > > _NET_WM_ICON(CARDINAL) = 
> > > WM_HINTS(WM_HINTS):
> > >                 Client accepts input or input focus: True
> > > XdndAware(ATOM) = ATOM
> > > WM_CLASS(STRING) = "dillo", "Dillo"
> > > _MOTIF_WM_HINTS(_MOTIF_WM_HINTS) = 0x1, 0x13, 0x1, 0x0, 0x0
> > > WM_NORMAL_HINTS(WM_SIZE_HINTS):
> > >                 program specified minimum size: 780 by 580
> > >                 program specified maximum size: 780 by 580
> > >                 window gravity: Static
> > > WM_PROTOCOLS(ATOM): protocols  WM_DELETE_WINDOW
> > > WM_ICON_NAME(STRING) = "Dillo: Splash screen for dillo-3.0.4.1"
> > > _NET_WM_ICON_NAME(UTF8_STRING) = "Dillo: Splash screen for dillo-3.0.4.1"
> > > WM_NAME(STRING) = "Dillo: Splash screen for dillo-3.0.4.1"
> > > _NET_WM_NAME(UTF8_STRING) = "Dillo: Splash screen for dillo-3.0.4.1"
> > 
> > For me it's:
> > 
> > > $ xprop
> > > WM_STATE(WM_STATE):
> > >                 window state: Normal
> > >                 icon window: 0x0
> > > _NET_WM_ICON(CARDINAL) =
> > > WM_HINTS(WM_HINTS):
> > >                 Client accepts input or input focus: True
> > > XdndAware(ATOM) = ATOM
> > > WM_CLASS(STRING) = "dillo", "Dillo"
> > > _MOTIF_WM_HINTS(_MOTIF_WM_HINTS) = 0x0, 0x1, 0x1, 0x0, 0x0
> > > WM_NORMAL_HINTS(WM_SIZE_HINTS):
> > >                 program specified minimum size: 100 by 101
> > >                 window gravity: Static
> > > WM_PROTOCOLS(ATOM): protocols  WM_DELETE_WINDOW
> > > WM_ICON_NAME(STRING) = "Dillo: Splash screen for dillo-3.0.4.1"
> > > _NET_WM_ICON_NAME(UTF8_STRING) = "Dillo: Splash screen for dillo-3.0.4.1"
> > > WM_NAME(STRING) = "Dillo: Splash screen for dillo-3.0.4.1"
> > > _NET_WM_NAME(UTF8_STRING) = "Dillo: Splash screen for dillo-3.0.4.1"
> > 
> > So yes, I see more realistic/useful size hints over here.
> > 
> > In case this is relevant, I'm not actually running the latest master
> > of dwm over here, but 7edc59631193813cf4d64030f8864de36b193cfc with custom patches.
> > I didn't get around to update the patches yet.
> 
> Could you please grep for NET_SUPPORTING in your dwm sources?
> In current dwm tip _NET_SUPPORTING_WM_CHECK is no longer set and
> this seems to cause ewmh_supported() to return 0 in my case.
> 
> Cheers,
> Johannes
> 
> _______________________________________________
> Dillo-dev mailing list
> [email protected]
> http://lists.dillo.org/cgi-bin/mailman/listinfo/dillo-dev