Re: here's 3.0.4.1 RC1

On Sun, Dec 07, 2014 at 06:36:02PM +0100, Johannes Hofmann wrote:
> Could you please grep for NET_SUPPORTING in your dwm sources?
> In current dwm tip _NET_SUPPORTING_WM_CHECK is no longer set and
> this seems to cause ewmh_supported() to return 0 in my case.

That flag doesn't exist over here in my code as well:

$ grep -r _NET
dwm.1:.B xprop -root -f _NET_WM_NAME 32a -set _NET_WM_NAME LG3D
dwm.c:                  setfullscreen(c, (cme->data.l[0] == 1 /* _NET_WM_STATE_ADD
dwm.c:                                || (cme->data.l[0] == 2 /* _NET_WM_STATE_TOGGL
dwm.c:  netatom[NetActiveWindow] = XInternAtom(dpy, "_NET_ACTIVE_WINDOW", False);
dwm.c:  netatom[NetSupported] = XInternAtom(dpy, "_NET_SUPPORTED", False);
dwm.c:  netatom[NetWMName] = XInternAtom(dpy, "_NET_WM_NAME", False);
dwm.c:  netatom[NetWMState] = XInternAtom(dpy, "_NET_WM_STATE", False);
dwm.c:  netatom[NetWMFullscreen] = XInternAtom(dpy, "_NET_WM_STATE_FULLSCREEN", Fals
dwm.c:  netatom[NetWMWindowType] = XInternAtom(dpy, "_NET_WM_WINDOW_TYPE", False);
dwm.c:  netatom[NetWMWindowTypeDialog] = XInternAtom(dpy, "_NET_WM_WINDOW_TYPE_DIALO
dwm.c:  netatom[NetClientList] = XInternAtom(dpy, "_NET_CLIENT_LIST", False);


On Sun, Dec 07, 2014 at 09:23:40PM +0100, Johannes Hofmann wrote:
> I have a fix that works on my system so far:
> 
> diff -r 72f0e7ccccc9 src/uicmd.cc
> --- a/src/uicmd.cc      Thu Nov 27 19:20:33 2014 +0000
> +++ b/src/uicmd.cc      Sun Dec 07 21:20:08 2014 +0100
> @@ -551,10 +551,10 @@
>     win->box(FL_NO_BOX);
>     CustTabs *DilloTabs = new CustTabs(ww, wh, 16);
>     win->end();
> +   win->resizable(DilloTabs->wizard());
>  
>     int focus = 1;
>     new_bw = UIcmd_tab_new(DilloTabs, old_ui, focus);
> -   win->resizable(DilloTabs->wizard());
>     win->show();
>  
>     if (old_bw == NULL && prefs.xpos >= 0 && prefs.ypos >= 0) {

That looks like a painful debugging experience...

> Please give it a try and report back if it breaks anything.

Didn't break anything over here.
It still works just as great as it did before. :-)


v4hn

_______________________________________________
Dillo-dev mailing list
[email protected]
http://lists.dillo.org/cgi-bin/mailman/listinfo/dillo-dev

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJUhNJcAAoJEKCfEUk/PuMmjtAQAJeUiP/WAROOZtCVpbbTAeyN
tTF96VABsH2i++Xmd69Oy9DUjp4wf1tOFvW9niy8lNf+F95CO20HMl2FPUvhoOGO
uREpzXbwUiPmOh2um/S1YoXwtXtIAYyF4oIUAI8nxKpNnOFNGWbp7qRiVX76+Wor
FyGfLhuix7QzsfNSgJRrz6jEnsGphOnUPmrWkl+vIh5bNR4muEZQutXTleVAKuoD
pepGi/MfHiV21bpBCHfceFnLC91Msrf+QbvN73bFZS0ruljMXBdIkw/uXEAviDt1
ywf69rXOscZZtx19Iug4sKrFFCa12fHllAdVpkaO35ayZUUHJcTc5pKBoBmUMyWo
wFZkY8Qxt1gSB+IU0kSqJYveZa3IV1J+r1h84uxjZk/UECCuiUN6P1jWYAEdG7IL
nDWh5NQR//me/GlGi9NaEvLvOcz3Cj8FG6FaHUhiuDNS8Pk/NNG7g6GZAozUNVvY
P18bGyixCHD1pyuXnE0MREu2jjtRTe4aKIJ3JUyHgS8FP4HhCP4aS0DqWnZkCvLT
39AxCZMsPmTLGn2aZNYOH9dGJ4T3g3Gdu73V97wb4cEh8J3TDzt9U8U22jQVHzrF
eyAHqVUuJS1dMhq416sGadVOSjYjdVGxFiEAyHIJ3hLomhS4FSUpS0MjntCc8kX3
1mRA7B4H0sqXuTLtG5YW
=TWF1
-----END PGP SIGNATURE-----