Re: https://www.google.com/search?ie=UTF-8&oe=UTF-8&q=dillo

Hi Seb,

On 24/04/16 12:24, Sebastian Geerken wrote:
> Hi!
>
> Since we do not have a tracking system, I suggest a new thread for
> every issue, with some identifier (e. g. a URL) as subject. Please
> focus on regressions: bugs not present in dillo 3.0.5.
>
> As for <https://www.google.com/search?ie=UTF-8&oe=UTF-8&q=dillo>, the
> problem are floating inline-blocks (see Johannes' posting and my
> answer). Floats positioned side by-side are not an issue for the next
> release, so I see two possibilities:
>
> 1. Leave it as it is, and start on an other positioning after the next
>     release.
>
> 2. Deactivate inline-blocks for the next release, and re-activate as
>     soon as side-by-side positioning of floats is implemented. This
>     way, dillo 3.1 would render Google like 3.0.5.
>
> The latter is rather simple:
>
> diff -r 7c2e27119432 src/html.cc
> --- a/src/html.cc       Sun Apr 24 12:21:07 2016 +0200
> +++ b/src/html.cc       Sun Apr 24 13:23:10 2016 +0200
> @@ -4036,7 +4036,7 @@
>                  Html_display_block(html);
>                  break;
>               case DISPLAY_INLINE_BLOCK:
> -               Html_display_inline_block(html);
> +               //Html_display_inline_block(html);
>                  break;
>               case DISPLAY_LIST_ITEM:
>                  Html_display_listitem(html);
>
> What do you think?

Magic!  That also fixes the big gaps where adverts are placed, i.e.:

http://www.boards2go.com/boards/board.cgi?user=dharrison

I like it - and as you say, once the other implementation is done, turn 
it on again.

Gets my vote, and I am running with it now :)

Thanks,

Nick
-- 
Gosh that takes me back... or is it forward?  That's the trouble with
time travel, you never can tell."
		-- Doctor Who "Androids of Tara"