Re: DefaultObjectWrapper

Attila,

On Sat, May 10, 2008 at 2:59 AM, Attila Szegedi <[email protected]> wrote:
> Completely threadsafe. You should have one per Configuration, and you
>  normally have one Configuration per your application. Struts should
>  really reference a single instance somehow, but instead of a static
>  singleton, the relevant object structure that does the tag parsing
>  would better have access to a Configuration object somewhere.

Thanks, I implemented a quick fix and the performance improvement is
noticeable in our automated tests.

It seems to me from looking over many of the classes used by
BeansWrapper that there is a lot of synchronization code that could be
improved with the use of 1.5 classes such as ConcurrentHashMap. For
example, the classCache in BeansWrapper or the cache variable in
ClassBasedModeFactory could easily be changed to concurrent hash maps
allowing for the unblocking of read operations for the typical case.

Would there be any objection if I was to submit some patches for this
against trunk?

Also, is there a timeline for 2.4?


Regards,

Bruce Ritchie

-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone