Re: GNOME CVS: galeon baddog

On 2003-02-08(Sat) 15:28:26 +0200, Yanko Kaneti wrote:
> 
> Its ok that you removed the variables that were no longer used but the
> pkg config line had its form for a reason. We directly include headers
> from all the packages on that line so its correct to include them all as
> direct dependencies, regardless of the fact that they are
> sub-dependencies of the other higher level packages we use.

Hm, I think PKG_CHECK_MODULES has a good reason to specify each and every
module, if they are versioned. It seems to me that (at least) a portion
of core gnome modules only specify dependencies where necessary -- only
unchained and versioned dependencies. If this is my misconception, then
I'll revert my change happily.


> So, please revert the pkconfig line change.
> Also when committing to galeon in the future please use the full
> ChangeLog entry for your cvs log message. In this case it would have
> been
>                                                                         
> 2003-02-07  Abel Cheung  <[email protected]>                                  
> 
> 	* configure.in: Removed superfluous building dependencies.

OK, I'll follow it.


> Thanks
> Yanko
> 
> 

-- 
Abel Cheung
GPG Key: (0xC67186FF) http://deaddog.org/gpg.asc

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQE+RjzOQVLh8cZxhv8RAlFUAKC/vU3G4Ah/c+G/J76OLi5V8DLwZACfXTIW
mwQs6WS5y/rA+vHNy+Aj/pE=
=arez
-----END PGP SIGNATURE-----