Re: [Patch] FTBFS - ia64, s390 and possibly others
Tommi Komulainen <[email protected]>
| Newsgroups | gmane.comp.web.galeon.devel |
|---|---|
| Message-ID | <[email protected]> |
On Thu, 2003-04-17 at 19:09, Mark Howard wrote:
> Hi,
> The Debian build machines are having trouble building from source on
> some architectures (ia64, s390, and possibly others still waiting to
> try). The following patch has been suggested to fix this, with reported
> success (both build and running). Please check and apply to cvs.
>
>
> --- mozilla/FilePicker.cpp.orig 2003-04-16 10:55:09.000000000 -0600
> +++ mozilla/FilePicker.cpp 2003-04-16 10:56:19.000000000 -0600
> @@ -147,8 +147,8 @@
> {
> guint bytesRead(0), bytesWritten(0);
> gchar *utf8DefaultString = g_filename_to_utf8(mDefaultString.get(), -1,
> - &bytesRead,
> - &bytesWritten, NULL);
> + (gsize *)&bytesRead,
> + (gsize *)&bytesWritten, NULL);
Hmm.. why the (suspicious) cast? Why not simply declare bytesRead and
bytesWritten as 'gsize' instead?
What are the sizes of guint and gsize on those architectures?
--
Tommi Komulainen [email protected]
GPG 1024D/68388EE6 6FD6 DD79 EB38 BF6F 3533 09C0 04A8 9871 6838 8EE6
signature.asc
(application/pgp-signature, 189 B)
-----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQA+ntzWBKiYcWg4juYRAqlGAKC4cEDUY+TT8F1vSj70Dzsttj0VAwCgthst otiZ+vuT+HSPPLpgj6P3JoY= =2neC -----END PGP SIGNATURE-----