Re: Tiny patch to center cookie prompt dialog

On Sun, 2003-06-22 at 20:26, Joseph Barillari wrote:
> Hi.
> 
> The "Accept cookie?" prompt dialog often appears partially off-screen
> in my Galeon setup. This is really irritating, as I have to drag it
> onto the screen to see the buttons. This one-line fix, submitted for
> your approval, should eliminate that problem:

> -  <property name="window_position">GTK_WIN_POS_NONE</property>
> +  <property name="window_position">GTK_WIN_CENTER_ON_PARENT</property>

Thanks, I committed this to CVS, although I'm not sure I see why it
would make any difference.  We're using gtk_window_set_transient_for to
make the dialog transient for its parent.  At least with metacity this
means, among other things, that the dialog gets centered on the parent.

Do other WM's need help with positioning transient dialogs? ;)

However, the logic with which the parent window is determined, is broken
(blame mozilla) and it sometimes gives us the wrong window, and
consequently the cookie dialog gets misplaced.  Maybe this is what
you've been seeing?


-- 
Tommi Komulainen                                 [email protected]
GPG 1024D/68388EE6    6FD6 DD79 EB38 BF6F 3533  09C0 04A8 9871 6838 8EE6

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)

iD8DBQA+9iWHBKiYcWg4juYRAt91AKDBy6IgjD5KCqlK8+HqI6MMSAolAQCfQc6+
xQ4ZkBUmXtL3gtjnuaFbTSM=
=/kL4
-----END PGP SIGNATURE-----