Re: Crippled 1.3.4? Or stupid user error?
Crispin Flowerday <[email protected]>
| Newsgroups | gmane.comp.web.galeon.devel |
|---|---|
| Message-ID | <1057006367.9536.5.camel@drno> |
> > > * How do I tell Galeon to override stupid pages with my legible
> > > fonts/colours? This was depressingly useful.
> >
> > Scratch an itch. We accept patches.
>
> Patch thy mother! IT WAS ALREADY THERE! It was part of why I
> switched to Galeon in the first place. Now it's gone, for no reason.
> I'm not going to submit a patch for something that was already there!
In general the best way to get something fixed is not to shout and
complain at developers who generally have things to do other that work
on galeon. (not that I claim to be developer, just a user with some
coding skill).
However in this case I have been meaning to add the menu entries. It was
surprisingly easy. And I even managed to force my fingers to type
color[sic] rather than the obviously more correct colour :)
One thing I did notice was that the own_colors pref doesn't appear to
cause mozilla to re-draw the page, whereas the fonts one does. Is this a
galeon or mozilla bug?
While on the subject of color vs colour could the following patch be
applied to give us en-GB people the proper language for sites that
support it.
diff -u -r1.15 general-prefs.c
--- general-prefs.c 21 Jun 2003 23:24:56 -0000 1.15
+++ general-prefs.c 30 Jun 2003 20:52:23 -0000
@@ -100,6 +100,7 @@
{ N_("Danish"), "da" },
{ N_("Dutch"), "nl" },
{ N_("English"), "en" },
+ { N_("English (British)"), "en-GB" },
{ N_("Esperanto"), "eo" },
{ N_("Estonian"), "et" },
{ N_("Faeroese"), "fo" },
cheers
Crispin
galeon_use_own_fonts_colors_menu.diff
(text/x-patch, 4 KB)
Index: src/galeon-window.c
===================================================================
RCS file: /cvs/gnome/galeon/src/galeon-window.c,v
retrieving revision 1.168
diff -u -r1.168 galeon-window.c
--- src/galeon-window.c 29 Jun 2003 14:38:37 -0000 1.168
+++ src/galeon-window.c 30 Jun 2003 20:44:18 -0000
@@ -76,6 +76,8 @@
#define ALLOW_POPUPS_TOGGLE_PATH "/commands/Allow Popups"
#define ALLOW_JAVA_PATH "/commands/Allow Java"
#define ALLOW_JAVASCRIPT_PATH "/commands/Allow JavaScript"
+#define USE_OWN_COLORS_PATH "/commands/Use Own Colors"
+#define USE_OWN_FONTS_PATH "/commands/Use Own Fonts"
#define ALLOW_POPUPS_CMD_PATH "/commands/AllowPopupSite"
#define ALLOW_COOKIES_CMD_PATH "/commands/AllowCookieSite"
#define BLOCK_COOKIES_CMD_PATH "/commands/BlockCookieSite"
@@ -97,6 +99,8 @@
#define ID_ALLOW_POPUPS "Allow Popups"
#define ID_ALLOW_JAVA "Allow Java"
#define ID_ALLOW_JAVASCRIPT "Allow JavaScript"
+#define ID_USE_OWN_FONTS "Use Own Fonts"
+#define ID_USE_OWN_COLORS "Use Own Colors"
typedef enum {
IMAGES,
@@ -748,6 +752,10 @@
eel_gconf_get_boolean(CONF_FILTERING_JAVASCRIPT_ENABLED));
gul_bonobo_set_toggle_state(ui_component, ALLOW_JAVA_PATH,
eel_gconf_get_boolean(CONF_FILTERING_JAVA_ENABLED));
+ gul_bonobo_set_toggle_state(ui_component, USE_OWN_FONTS_PATH,
+ eel_gconf_get_boolean(CONF_RENDERING_USE_OWN_FONTS));
+ gul_bonobo_set_toggle_state(ui_component, USE_OWN_COLORS_PATH,
+ eel_gconf_get_boolean(CONF_RENDERING_USE_OWN_COLORS));
}
//Prototype needed as implemented later
@@ -825,6 +838,10 @@
eel_gconf_get_boolean (CONF_FILTERING_JAVASCRIPT_ENABLED));
gul_bonobo_set_toggle_state(ui_component, ALLOW_JAVA_PATH,
eel_gconf_get_boolean (CONF_FILTERING_JAVA_ENABLED));
+ gul_bonobo_set_toggle_state(ui_component, USE_OWN_FONTS_PATH,
+ eel_gconf_get_boolean(CONF_RENDERING_USE_OWN_FONTS));
+ gul_bonobo_set_toggle_state(ui_component, USE_OWN_COLORS_PATH,
+ eel_gconf_get_boolean(CONF_RENDERING_USE_OWN_COLORS));
bonobo_ui_component_add_listener(ui_component, ID_ALLOW_POPUPS,
(BonoboUIListenerFn)allow_popups_bonoboui_changed_cb,
@@ -838,6 +855,12 @@
bonobo_ui_component_add_listener(ui_component, ID_ALLOW_JAVA,
(BonoboUIListenerFn)allow_setting_bonoboui_changed_cb,
CONF_FILTERING_JAVA_ENABLED);
+ bonobo_ui_component_add_listener(ui_component, ID_USE_OWN_COLORS,
+ (BonoboUIListenerFn)allow_setting_bonoboui_changed_cb,
+ CONF_RENDERING_USE_OWN_COLORS);
+ bonobo_ui_component_add_listener(ui_component, ID_USE_OWN_FONTS,
+ (BonoboUIListenerFn)allow_setting_bonoboui_changed_cb,
+ CONF_RENDERING_USE_OWN_FONTS);
eel_gconf_notification_add(CONF_FILTERING_ALLOW_POPUPS,
(GConfClientNotifyFunc)allow_popups_gconf_changed_cb,
@@ -851,6 +874,12 @@
eel_gconf_notification_add(CONF_FILTERING_JAVA_ENABLED,
(GConfClientNotifyFunc)allow_setting_gconf_changed_cb,
ui_component);
+ eel_gconf_notification_add(CONF_RENDERING_USE_OWN_FONTS,
+ (GConfClientNotifyFunc)allow_setting_gconf_changed_cb,
+ ui_component);
+ eel_gconf_notification_add(CONF_RENDERING_USE_OWN_COLORS,
+ (GConfClientNotifyFunc)allow_setting_gconf_changed_cb,
+ ui_component);
}
static void
Index: ui/galeon-ui.xml.in
===================================================================
RCS file: /cvs/gnome/galeon/ui/galeon-ui.xml.in,v
retrieving revision 1.70
diff -u -r1.70 galeon-ui.xml.in
--- ui/galeon-ui.xml.in 21 Jun 2003 18:37:37 -0000 1.70
+++ ui/galeon-ui.xml.in 30 Jun 2003 20:44:19 -0000
@@ -397,6 +397,15 @@
<separator/>
+ <menuitem name="ShortcutsFonts" id="Use Own Fonts" type="toggle"
+ _label="Use own _fonts" _tip="Use default fonts instead of page-requested fonts"
+ verb=""/>
+
+ <menuitem name="ShortcutsColors" id="Use Own Colors" type="toggle"
+ _label="Use own _colors" _tip="Use default colors instead of page-requested colors"
+ verb=""/>
+ <separator/>
+
<menuitem name="ShortcutsJava" id="Allow Java" type="toggle"
_label="Allow _Java" _tip="Toggle allowing of java applets to run"
verb=""/>