Re: [PATCH] favicons in tabs

On Tue, 2003-07-22 at 03:10, Juho Snellman wrote:
> Attached patch restores support (Galeon 1.2 style) for showing
> favicons in tabs. The appearance (never show, always show, show if
> non-default icon) is configurable using a gconf variable. Since the
> the gconf key is already documented in README.ExtraPrefs, this
> shouldn't count as adding a new useless feature... ;-)
> 
> One note on the implementation: changing the value of the gconf
> variable won't affect existing tabs, only ones created afterwards.

A couple of comment; firstly is the patch complete? I ask because there
doesn't seem to be an implementation of the galeon_favicon_set_mode
function.

Also by removing the ge_favicon signal callback, I don't think that the
favicon cache will get updated. And from my brief glance at the patch it
looks as though dragging a tab from one window to another may lose the
icon.

I was also looking at this last night, and did it by copying the code
from epiphany. The epiphany notebook has a couple of nice features like
dnd onto and from the tab labels, and also a nice spinny icon when a
page is loading.

Crispin



-------------------------------------------------------
This SF.net email is sponsored by: VM Ware
With VMware you can run multiple operating systems on a single machine.
WITHOUT REBOOTING! Mix Linux / Windows / Novell virtual machines at the
same time. Free trial click here: http://www.vmware.com/wl/offer/345/0