Re: [PATCH] favicons in tabs
Juho Snellman <[email protected]>
| Newsgroups | gmane.comp.web.galeon.devel |
|---|---|
| Message-ID | <[email protected]> |
On Tue, Jul 22, 2003 at 09:58:11AM +0100, Crispin Flowerday wrote: > A couple of comment; firstly is the patch complete? I ask because there > doesn't seem to be an implementation of the galeon_favicon_set_mode > function. Oops, sorry about that. I had to edit the patch by hand, and must have cleaned it a bit too much. However, I won't post an updated patch since... > I was also looking at this last night, and did it by copying the code > from epiphany. ... we should probably avoid unneccessary divergence from Epiphany. > Also by removing the ge_favicon signal callback, I don't think that the > favicon cache will get updated. Ah, also my mistake. I grepped for ge_favicon only in **/*.c (missing GaleonWrapper.cpp), so it looked like orphan code. -- Juho Snellman ------------------------------------------------------- This SF.net email is sponsored by: VM Ware With VMware you can run multiple operating systems on a single machine. WITHOUT REBOOTING! Mix Linux / Windows / Novell virtual machines at the same time. Free trial click here: http://www.vmware.com/wl/offer/345/0