Re: Find bookmarks comments

El jue, 21-08-2003 a las 08:30, Tommi Komulainen escribió:
> Hi,
> 
> Heh, I probably would've missed the brand new bookmarks find dialog if
> Crispin hadn't mentioned it to me.  So now you know who to thank ;)
>
> Anyway, besides the non-english labels, lack of mnemonics and oddly
> non-higgy (excuse my french) looking spacing in the options dialog,

well, it's not finished, as stated in the Changelog entry. 
And I didn't notice the non-english labels ;)

> having a separate dialog for finding bookmarks just feels wrong; now
> there's two separate windows showing bookmarks and the two don't seem to
> be connected in any way.

I did the current dialog thinking primarily in the sidebar, where it
would be most useful.

The don't seem connected because they are not connected actually. Except
that the find dialog is accessed form the bm editor menu at the momment.

> We figured it would be better to have something similar to evolution or
> rhythmbox (or ephy) where you have the search entry in the same window
> as the bookmarks.  It would make the search much more obvious, IMHO. 
> And yes, I know it's probably more difficult to implement too :-/

It is not too more difficult to implement.
But I think it can be confusing. 

The treeview in the bookmark editor shows an hierarchy of bookmarks. 

The treeview in the find dialog shows a list of bookmarks. Hence, when
you start searching the meaning of the treeview would change which would
be confusing, in my opinion.

We could add yet another mode to the bookmark editor to avoid this
confusion, but I thought that a separate dialog would be cleaner. 

> Should we include that search on the location entry autocompletion?

how?

FWIW, urls from bookmarks are already used for autocompletion

> 
> Don't take this the wrong way, but I think there should be some sort of
> (mockup-)review before making significant changes to UI.  While we want 
> to have find for bookmarks, the initial implementation just feels wrong.

Consider the current implementation that mockup. That's why I commit it
before it is really finished.

> Comments?  Flames?
> 
> 
> Hmm... should this be discussed on galeon-devel?  Just to have more
> public record or something?

Of course, CCing there.

-- 
Ricardo Fernández Pascual
[email protected]
Murcia. España.




-------------------------------------------------------
This SF.net email is sponsored by: VM Ware
With VMware you can run multiple operating systems on a single machine.
WITHOUT REBOOTING! Mix Linux / Windows / Novell virtual machines
at the same time. Free trial click here:http://www.vmware.com/wl/offer/358/0