Re: Re: Find bookmarks comments

On Fri, 2003-08-22 at 18:55, Ricardo Fernández Pascual wrote:
> El jue, 21-08-2003 a las 08:30, Tommi Komulainen escribió:
> 
> well, it's not finished, as stated in the Changelog entry. 
> And I didn't notice the non-english labels ;)

And contrary to the ChangeLog, it seems that now you forgot to actually
commit the glade file :)


> > having a separate dialog for finding bookmarks just feels wrong; now
> > there's two separate windows showing bookmarks and the two don't seem to
> > be connected in any way.
> 
> I did the current dialog thinking primarily in the sidebar, where it
> would be most useful.
> 
> The don't seem connected because they are not connected actually. Except
> that the find dialog is accessed form the bm editor menu at the momment.

Hmm..  I suppose I'm missing even bigger picture here then.  Where
exactly is this dialog going to be used in?


> > We figured it would be better to have something similar to evolution or
> > rhythmbox (or ephy) where you have the search entry in the same window
> > as the bookmarks.  It would make the search much more obvious, IMHO. 
> > And yes, I know it's probably more difficult to implement too :-/
> 
> It is not too more difficult to implement.
> But I think it can be confusing. 
> 
> The treeview in the bookmark editor shows an hierarchy of bookmarks. 
> 
> The treeview in the find dialog shows a list of bookmarks. Hence, when
> you start searching the meaning of the treeview would change which would
> be confusing, in my opinion.
> 
> We could add yet another mode to the bookmark editor to avoid this
> confusion, but I thought that a separate dialog would be cleaner. 

In mozilla the bookmarks editor shows the hierarchy initially, and when
you start the search it just switches to flat search results.  I think
that would be quite obvious in at least the single-paned view.

Similarly in epiphany when you start the search, the topic pane
automatically switches to 'All' and also shows the search results in a
flat list (not that there's any hierarchy there at all) in the bookmark
pane.

Considering the existing examples, I don't think there'd be much
confusion having the treeview switch from hierarchic to flat list when
showing search results.


> > Should we include that search on the location entry autocompletion?
> 
> how?
> 
> FWIW, urls from bookmarks are already used for autocompletion

Well, I was thinking about having the autocompletion window show the
results in a similar way to the bookmarks find dialog.  That is,
emphasize the page titles instead of the URLs.  But I don't know if
that's going to work well in practice.


> Consider the current implementation that mockup. That's why I commit it
> before it is really finished.

Ah, well..  I guess I was just expecting some prior warning, because
it's usually much easier to make even big changes if all you've done so
far is just the mockup.  But if commit first, fix later if ever, is the
current practice, nevermind me then...


-- 
Tommi Komulainen                                 [email protected]
GPG 1024D/68388EE6    6FD6 DD79 EB38 BF6F 3533  09C0 04A8 9871 6838 8EE6

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)

iD8DBQA/SRQaBKiYcWg4juYRAhZTAKCwqIZgdy3aLNk4Vp1R9qQ/1C9aCQCg9PeA
juSoTgDz5IsDqA3ueBFT4HU=
=dZyL
-----END PGP SIGNATURE-----