Re: Regarding my old mmap patch
Charlie Reitzel <[email protected]> Tue, 05 Sep 2006 21:50:22 -0400
| Newsgroups | gmane.comp.web.html-tidy.devel |
|---|---|
| Message-ID | <[email protected]> |
That all sounds accurate. IIRC, I did work on refactoring the I/O chain to allow for character transcoding independently of the input/output source. But I found the transcoding logic was pretty tightly meshed with the I/O (especially pretty print on output). Today, I would vote to simply layer Tidy over iconv, which is widely available (I know, many suggested this at the time). Back to the topic at hand, do you agree that we should strive to encapsulate platform dependencies? At 12:06 AM 9/6/2006 +0200, Bjoern Hoehrmann wrote: >* Charlie Reitzel wrote: > >I'd have to cast my vote as "no" on committing this patch for one simple > >reason. It introduces too much platform-specific code into too many > >files. Ideally, all platform considerations are kept in platform.h. The > >MLANG addition was one exception to this that, imo, should be removed (as > >it was not finished). > >There is very little MLang code outside win32tc.c, and the bits that are >there exist simply because Tidy lacks an appropriate interface for other >transcoders. You wanted to work on that, but so far the issues have not >been addressed in the code, and hence the artifacts remain. ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Tidy-develop mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/tidy-develop