Re: Regarding my old mmap patch

I have a really dumb question for everyone: who is running Tidy on large 
files?  To be honest, it just seems weird to me.  I know you guys aren't 
doing this for your health, so I'd like to understand it better.  More below.

At 10:21 AM 9/5/2006 -0700, Cory Nelson wrote:
>On 9/5/06, Charlie Reitzel <[email protected]> wrote:
>>Ideally, all platform considerations are kept in platform.h.
>
>Perhaps all this could be moved into a mmap_win32.c then?  I already
>strongly dislike platform.h already because it brings in so many
>includes/defines that a public API shouldn't.

How about a mmap.c, which contains both your and Nuno's code.  These look 
more alike than different.  We would still need a few #defines in 
platform.h to enable the contents of mmap.c (and specify either the POSIX 
or Windows implementations and perhaps others downstream).

>>Put another way, why not use memory-mapped files on all (or at least most)
>>platforms?  Unix, Linux, Windows, OS/2, and probably Mac/X, should all
>>support this functionality.  So a compromise might be to wrap the Windows
>>shared-memory APIs to look like Unix.
>
>I have little experience mmapping on *nix but I do understand they are
>different enough that it would probably take more code to wrap it than
>to just maintain separate files with the same APIs.

I think Nuno's patch shows the similarities - at least for this 
application.  I would gladly trade a small % performance improvement for a 
large portability improvement.

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

_______________________________________________
Tidy-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tidy-develop