Re: patch for 2407470
"Wolfgang Fahl" <[email protected]> Thu, 20 Aug 2009 10:18:31 +0200
| Newsgroups | gmane.comp.web.httpunit.devel |
|---|---|
| Organization | BITPlan GmbH |
| Message-ID | <[email protected]> |
Dear Adam and redsonic, http://httpunit.svn.sourceforge.net/viewvc/httpunit?view=rev&revision=1042 has the proposed change. I was not able to reproduce you problem. There is a JUnit testcase WebFormTest.testGetFormWithID() that is reserved for this purpose. You might want to show how the old state of httpunit 1.7 failed. Otherwise it might be that the change gets reverted again. Yours Wolfgang > In httpunit 1.6.2, I had a document with a <form> that had an id. My > test case then looked that up, with getFormWithID, and all was right > in the world. > > This fails with httpunit 1.7. > > I'm thinking this failure is the same one as 2407470. From my > debugging of the issue, when the document is being parsed, any/all > script tags are run, and/or the scripting engine(s) are started. The > javascript engine tries to get a list of forms. Since this happens > 'early', there are no proxies around the raw dom, so those get > created. However, now once javascript is loaded, the dom walking > continues processing. When it gets to the form element, it is already > in the ElementRegistry, so never gets added to the map/list internal > look variables. > > Anyways, the attached patch fixes my problem for me, and seems rather > small. It also makes the public getFoo functions more similiar. > > http://sourceforge.net/tracker/index.php?func=detail&aid=2407470&group_id=6550&atid=106550 > > ps: I am not subscribed, please cc me > BITPlan - smart solutions Pater-Delp-Str. 1, D-47877 Willich Schiefbahn Tel. +49 2154 811-480, Fax +49 2154 811-481 Web: http://www.bitplan.de bitplan GmbH, Willich - HRB 6820 Krefeld, VAT-ID: 10258040548, Geschäftsführer: Wolfgang Fahl ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Httpunit-develop mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/httpunit-develop