Re: Re: patch: generate *.gmo files to the source directory

Kalle Olavi Niemitalo <[email protected]> wrote Sun, Dec 04, 2005:
> Kalle Olavi Niemitalo <[email protected]> writes:
> 
> > Here is a simple patch that makes po/Makefile.am tell msgfmt to
> > store the *.gmo files in the source directory, rather than in the
> > build directory.  This is a good idea for two reasons:
> >
> > * The install-data-local-yes target installs those files from the
> >   source directory and ignores files in the build directory.

This should not be the case anymore.

> > * The files are listed in EXTRA_DIST, so they end up in the *.tar.gz
> >   and are eventually extracted to the source tree.

This is due to the fact that we don't require people to have the
gettext-tools installed. 

> >   If they were
> >   later regenerated into the build directory, then there would be
> >   different versions in different directories, causing
> >   confusion.

I don't see why it causes confusion. I mean, if you do out-of-tree
builds you should know what you are doing. Also, it would do the wrong
thing if I have multiple build trees based on one source tree (for
example several trees related to different bugs or features where you
use cg-switch in the source tree to check out my work).

> Apparently, this has not been applied.  Here is a new patch
> relative to a recent version from GIT.

I am sorry it didn't even receive a comment.

> I changed the %.gmo rule to use $@ instead of a shell variable,
> and made various tweaks in it to better support strange file names,
> e.g. spaces in $(srcdir).  I suppose other makefiles in ELinks
> do not support those, but one must start somewhere.  I don't think
> it will ever be feasible to support backslashes and quotes without
> horrible contortions, but spaces should be doable.
>
> I have also taken the liberty to remove the SUFFIXES variable and
> the .SUFFIXES rule.  According to the documentation, GNU Make
> uses them only for suffix rules, which have been replaced with
> pattern rules in po/Makefile.  The makefiles included by
> po/Makefile do not define suffix rules, either.

Any chance you could post these changes in a separate patch?
 
> The dist target in po/Makefile does not work, because it depends
> on distdir, for which there is no rule.  I did not remove it yet,
> because I don't know if some is working on it.

Yeah, cool. I have removed the now obsoleted dist target.

-- 
Jonas Fonseca
_______________________________________________
elinks-dev mailing list
[email protected]
http://linuxfromscratch.org/mailman/listinfo/elinks-dev