Re: [patch] Resolve not the name put in header

Hello.
Jonas Fonseca wrote:

>Michael Somebody <[email protected]> wrote Sun, Dec 04, 2005:
>  
>
>>The patch following allows to enter in options dialog (for one session
>>only) one host name to redirect all requests to. This is intended for
>>debugging or tunneling sites which have virtual hosts. I hope someone
>>will find it useful and maybe it'll be merged in the source.
>>    
>>
>
>I don't quite understand the tunneling part since there is only one
>configurable address, so you'd have to change it for each new site.
>  
>
Example where I will test the patch soon since I haven't got direct 
access to it: someone tunnels
local-only server out of  local network to a port on the working 
machine. It's really enough to
resolve every such tunnel to the working machine, and I hope the ports 
won't upset virtual host
directive in Apache.

>>---------patch begins------------
>>    
>>
>
>A few comments. The patch seems to be whitespace corrupted.
>  
>
I'm sorry. Maybe I shall post not from Thunderbird next time - or I 
shall attach the patch
instead.

>>+	FILE * log;
>>+
>>    
>>
>
>The log variable seems to be leftovers from your debugging.
>BTW, you can log to a file using LOG_{ERR,WARN,INFO,DBG} etc.
>See src/util/error.h for info about env variables to set the log file
>and the log level.
>
>  
>
Thanks. This is my error. It can (and will) be removed.

>>+	if ((singleaddr=get_opt_str("protocol.single-address")) )
>>    
>>
>
>get_opt_str() always returns non-NULL, since all options are always
>asserted to exist.
>  
>
It seems strange to me. I hadn't realized this before writing the patch

>> 		"domains as well. If it's blank, NO_PROXY environment 
>> 		variable is\n"
>> 		"checked as well.")),
>>
>>+	INIT_OPT_STRING("protocol", N_("One address to replace all the ip
>>queries"),
>>+		"single-address", 0, "",
>>+		N_("All the queries will be sent with usual headers but to 
>>this IP.")),
>>+
>> 	NULL_OPTION_INFO,
>> };
>> static struct module *protocol_submodules[] = {
>>    
>>
>
>I somehow feel this option belongs in the 'connections' subtree which is
>more lowlevel than 'protocol', and also this really isn't related to any
>protocol part but to connection setup.
>
>  
>
Thank you one more time. I'll move it before posting a next version 
(after some bugfix?). Really I looked
for such a feature and found only URI rewriting - that's why I put my 
option near it.

>[ CC'ed you since I cannot remember if you subscribed. ]
>  
>
I have just subscribed. After not finding this feature.

Good bye.
_______________________________________________
elinks-dev mailing list
[email protected]
http://linuxfromscratch.org/mailman/listinfo/elinks-dev