Revert Python goto_url_hook change before 0.11.3?

Kalle Olavi Niemitalo <[email protected]> Thu, 05 Apr 2007 00:45:28 +0300

Newsgroups	gmane.comp.web.links
Message-ID	<[email protected]>

I'd like to revert this commit from ELinks 0.11.2.GIT before
0.11.3 is released:

commit 8bedf25bf84d60b143b16d0fe1b384dc17c93569
tree 4b752e88247d9722399bab58d08d748f215388ea
parent e1ae6a0cdf12f05a0f642f70de02c513c69648e5
author witekfl <witekfl@laptop.(none)> Sun, 29 Jan 2006 14:58:03 +0100
committer Jonas Fonseca <[email protected]> Mon, 27 Nov 2006 17:13:02 +0100

    * contrib/python/hooks.py, src/scripting/python/hooks.c:

    goto_url_hook takes 2 params not 1. Some dumbprefixes defined
    in hooks.py

ELinks 0.11.0, 0.11.1, and 0.11.2 call the Python goto_url_hook
with one argument: the current URI.  This commit changes
goto_url_hook(current) to goto_url_hook(new, current): the new
URI typed by the user becomes the first parameter.  ELinks
0.12.GIT calls the hook as goto_url_hook(new): the hook no longer
gets the current URI as a parameter but can instead read that
From a separate function.

So we have three different calling conventions here.  I think it
will be less confusing to users if we drop the middle one and
make the rest of the stable 0.11 branch call the hook in the same
way as 0.11.2 did.  The difference would then be only between the
0.11 and 0.12 branches.

Objections?

_______________________________________________
elinks-dev mailing list
[email protected]
http://linuxfromscratch.org/mailman/listinfo/elinks-dev

signature.asc (application/pgp-signature, 188 B)

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFGFByHHm9IGt60eMgRArdhAKDIXHaq37NAzTYSrKiJJ27tWMHaVQCgu6jl
YkWdw4jGifsv392IzKej9PY=
=ZWA1
-----END PGP SIGNATURE-----