Re: Revert Python goto_url_hook change before 0.11.3?

Jonas Fonseca <[email protected]>
Newsgroups gmane.comp.web.links
Message-ID <[email protected]>
Kalle Olavi Niemitalo <[email protected]> wrote Thu, Apr 05, 2007:
> I'd like to revert this commit from ELinks 0.11.2.GIT before
> 0.11.3 is released:
> 
> commit 8bedf25bf84d60b143b16d0fe1b384dc17c93569
> tree 4b752e88247d9722399bab58d08d748f215388ea
> parent e1ae6a0cdf12f05a0f642f70de02c513c69648e5
> author witekfl <witekfl@laptop.(none)> Sun, 29 Jan 2006 14:58:03 +0100
> committer Jonas Fonseca <[email protected]> Mon, 27 Nov 2006 17:13:02 +0100
> 
>     * contrib/python/hooks.py, src/scripting/python/hooks.c:
> 
>     goto_url_hook takes 2 params not 1. Some dumbprefixes defined
>     in hooks.py
> 
...
> So we have three different calling conventions here.  I think it
> will be less confusing to users if we drop the middle one and
> make the rest of the stable 0.11 branch call the hook in the same
> way as 0.11.2 did.  The difference would then be only between the
> 0.11 and 0.12 branches.
> 
> Objections?

Sound like a good idea!

-- 
Jonas Fonseca
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.