Re: [PROPOSAL] Release v2.2.0 of Maverick

Before releasing 2.2 there is a bug I noticed a while ago that doesn't 
seem to have been fixed.

The problem is that the UNFINISHED_CONTENTTYPE isn't explicitly set 
when maxTransforms=0. This caused problems on some browsers, primarily 
IE 5.2 for Mac.

To fix this I add the following lines to the getNextStep() method in 
MaverickContext.java.

      if (this.transformCount == 0)
          this.getRealResponse().setContentType(UNFINISHED_CONTENTTYPE);

These lines were added within the 'if' statement. The new 'if' 
statement looks as follows.

if (this.nextTransform >= this.transformCount)
{
      if (this.transformCount == 0)
          this.getRealResponse().setContentType(UNFINISHED_CONTENTTYPE);

      this.log.debug("...which is the LastStep");
      return new LastStep(this);
  }

There is also a patch attached for the version contained in the 2.1.2 
release.

Note: This may not be the best solution to the problem.

-- Mike



On Friday, March 21, 2003, at 05:30 PM, Schnitzer, Jeff wrote:

> Yes, definitely worthwhile.  My own projects use the 
> latest-and-greatest
> third-party jars with no ill effect.  I'll update the ones in CVS.
>
> With that change, is everyone comfortable with a 2.2 release?
>
> Jeff Schnitzer
> [email protected]
>
>
>> -----Original Message-----
>> From: Robert Leftwich [mailto:[email protected]]
>> Sent: Friday, March 21, 2003 4:07 PM
>> To: [email protected]
>> Subject: RE: [Mav-user] Accessing the Command string from the
> controller -
>> Correction
>>
>> At 10:09 AM 22/03/2003, Schnitzer, Jeff wrote:
>>
>>> BTW, I recommend using the CVS copy of Maverick right now - the
>>> getParams() method has been renamed to getControllerParams().
>>
>> I wonder if it is worthwhile updating some (all?) of the libs in the
> CVS
>> as
>> they are quite old and the newer versions have had significant
>> enhancement:?
>>
>> Has anyone been running Maverick with the latest and greatest jdom,
>> bean-utils, collections and log4j? Any problems?
>>
>> Robert
>>
>>
>>
>>
>> -------------------------------------------------------
>> This SF.net email is sponsored by:Crypto Challenge is now open!
>> Get cracking and register here for some mind boggling fun and
>> the chance of winning an Apple iPod:
>> http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0031en
>> [INVALID FOOTER]
>
>
>
> -------------------------------------------------------
> This SF.net email is sponsored by:Crypto Challenge is now open!
> Get cracking and register here for some mind boggling fun and
> the chance of winning an Apple iPod:
> http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0031en
> [INVALID FOOTER]

*** ../maverick.1/src/java/org/infohazard/maverick/flow/MaverickContext.java	Thu Dec 12 15:16:24 2002
--- src/java/org/infohazard/maverick/flow/MaverickContext.java	Tue Feb 18 15:22:48 2003
***************
*** 26,31 ****
--- 26,34 ----
  	 */
  	private static Category log = Category.getInstance(MaverickContext.class.getName());
  	
+ 	/** Mime type used if we stop before last transform. */
+ 	protected final static String UNFINISHED_CONTENTTYPE = "text/xml";
+ 	
  	/**
  	 */
  	protected Dispatcher dispatcher;
***************
*** 188,193 ****
--- 191,199 ----
  			
  		if (this.nextTransform >= this.transformCount)
  		{
+ 			if (this.transformCount == 0)
+ 				this.getRealResponse().setContentType(UNFINISHED_CONTENTTYPE);
+ 
  			this.log.debug("...which is the LastStep");
  			return new LastStep(this);
  		}