Re: midgard-apache scfg vs dcfg

"Jukka Zitting" <[email protected]> wrote:

> Hi,

Hi,
 
> > Shouldn't authtype be set as member of directory_config instead of server_config ?
> > Or server_config and directory_config points to the same vhost?
> 
> Ideally we should be fine with just directory_config, it's much more
> flexible than server_config and covers most use cases just as well.
> The server_config stuff is a remnant of the time when I knew little of
> Apache internals. Unfortunately the server_config has since grown
> quite a lot, so refactoring it might be a bit error-prone.

The problem is that AuthType command sets correct midgard_auth_type
while authtype is set to initial MGD_AUTHYPE_NORMAL value 
in midgard_translate_handler.

Both , for scfg and dcfg. 
I have no idea what's happening before midgard_translate_handler.
 
> PS. I'd very much like to have the apache*.h files moved from
> midgard-core to midgard-apache*. There are a couple of nasty
> interdependencies with midgard-php, but I suppose those could be
> refactored away. Can we already start doing this or would it be better
> to do it post-1.8?

Yes, especially as we do not need apache.h and apache2.h.
I am not going to change anything, clean time begins when 1.8 stable is out.

Piotras