Re: polipo and NetworManager

Hi Juliusz,
Hi list,

New proposal is git push -f on my git repository :
https://github.com/caeies/polipo-caeies/commit/9bb2c8e8fa48642968819790d7881d35d5851b7e

As suggested by Juliusz, I reparse the resolv.conf file and reinitialise the
nameserverAddress. I hope it's ok with you.

I've tested as much as I can (so not so much, but it looks working for me).
Other tests are welcome !.

All comments welcome.

Best regards,

Caeies.

2011/6/22 Caeies Polipo <[email protected]>

> Sorry was off list.
>
> 2011/6/15 Juliusz Chroboczek <[email protected]>
>
>> > What do you think ?
>>
>> That it's a good idea, but needs some more work.
>>
>> First, I think you're not resetting nameserverAddress correctly.
>>
> Ok, I will try to fix that quickly.
>
>
>>
>> Second, there's no need for a lock -- Polipo is event-driven, not
>> threaded code.  The race condition is elsewhere -- if a reply arrives
>> between resetDns and establishDnsSocket, you'll lose a reply.  I suggest
>> calling establishDnsSocket from within resetDns.
>>
> Ok.
>
>
>>
>> Third, please use four spaces for indentation, and avoid C99 comments
>> (//).
>>
> Yeah, sorry, My last patch (not yet pushed) try to fix that. I will update
> them when reworking the commit.
>
>
>>
>> (You'll want to ``git rebase -i'' and ``git push --force'' in order to
>> provide me with a clean patch history after you make your changes.)
>>
> Thanks for your tip, I'm not so fluently speaking git :).
>
>  Regards,
>
> Caeies.
>
>>
>> -- Juliusz
>>
>
>
------------------------------------------------------------------------------
Simplify data backup and recovery for your virtual environment with vRanger.
Installation's a snap, and flexible recovery options mean your data is safe,
secure and there when you need it. Data protection magic?
Nope - It's vRanger. Get your free trial download today.
http://p.sf.net/sfu/quest-sfdev2dev