Re: polipo and NetworManager
Caeies Polipo <[email protected]>
| Newsgroups | gmane.comp.web.polipo.user |
|---|---|
| Message-ID | <[email protected]> |
Sorry was off list. 2011/6/15 Juliusz Chroboczek <[email protected]> > > What do you think ? > > That it's a good idea, but needs some more work. > > First, I think you're not resetting nameserverAddress correctly. > Ok, I will try to fix that quickly. > > Second, there's no need for a lock -- Polipo is event-driven, not > threaded code. The race condition is elsewhere -- if a reply arrives > between resetDns and establishDnsSocket, you'll lose a reply. I suggest > calling establishDnsSocket from within resetDns. > Ok. > > Third, please use four spaces for indentation, and avoid C99 comments (//). > Yeah, sorry, My last patch (not yet pushed) try to fix that. I will update them when reworking the commit. > > (You'll want to ``git rebase -i'' and ``git push --force'' in order to > provide me with a clean patch history after you make your changes.) > Thanks for your tip, I'm not so fluently speaking git :). Regards, Caeies. > > -- Juliusz > ------------------------------------------------------------------------------ Simplify data backup and recovery for your virtual environment with vRanger. Installation's a snap, and flexible recovery options mean your data is safe, secure and there when you need it. Data protection magic? Nope - It's vRanger. Get your free trial download today. http://p.sf.net/sfu/quest-sfdev2dev